From b9620ec71cd4475aabce13df6e5c25c0c3bcdccd Mon Sep 17 00:00:00 2001 From: Boris Zbarsky Date: Fri, 9 Jul 2021 01:11:59 -0400 Subject: [PATCH] Add CI for disabling detail logging. (#8171) This way we won't have to worry about problems popping up if/when someone tries to do that. For now assuming no one really plans to disable error logging. --- .github/workflows/build.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index efe7ec04a0343a..86f382d23a0b06 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -30,9 +30,12 @@ jobs: strategy: matrix: - type: [gcc_debug, gcc_release, clang, mbedtls, clang_experimental] + type: [gcc_debug, gcc_release, clang, mbedtls, clang_experimental, no_detail_logging] + # Disabling progress logging does not compile yet. Once it does, we can add the no_progress_logging type. env: BUILD_TYPE: ${{ matrix.type }} + DETAIL_LOGGING: ${{ matrix.type != 'no_detail_logging' && matrix.type != 'no_progress_logging' }} + PROGRESS_LOGGING: ${{ matrix.type != 'no_progress_logging' }} runs-on: ubuntu-latest if: github.actor != 'restyled-io[bot]' @@ -85,7 +88,7 @@ jobs: *) ;; esac - scripts/build/gn_gen.sh --args="$GN_ARGS" + scripts/build/gn_gen.sh --args="$GN_ARGS chip_detail_logging=${DETAIL_LOGGING} chip_progress_logging=${PROGRESS_LOGGING}" - name: Run Build timeout-minutes: 10 run: scripts/build/gn_build.sh