Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove link to addon directory at exit of blender - take 2 #2 #183

Closed
wants to merge 49 commits into from
Closed

Remove link to addon directory at exit of blender - take 2 #2 #183

wants to merge 49 commits into from

Conversation

Mateusz-Grzelinski
Copy link
Collaborator

Work and design still in progress.

This PR fixes issues that pop up in ugly corner cases in various places:

  • uninstalling addon from blender might lead to data loss
  • importing data from previous blender converts junction (link) into directory what leads to permission error when trying to install addon

Design 1 - link only when debugging - implemented in this PR

  • temporary link to addon dir is made only for VS code session - proposed in Remove link to addon directory at exit of blender #55 but not merged, so
    • add new setting to go back to previous behaviour - simple
    • or create a command "Blender: Install addons" that links/installs addons permamently - might be complicated - addons can have different ways of installation.

Design 2 - modify addon directory

  • modify VS code startup to use separate addon BLENDER_USER_SCRIPTS and dir BLENDER_SYSTEM_EXTENSIONS
    • need to be carefull to prioritize directory that user sets

In this PR implemented:

  • Done: Disable "Load Previous settings" blender feature during VS code session.
  • Done: send notification if linking addon failed
  • Done: make addon link/junction temporary
    • add setting to fallback to old behaviour blender.addon.keepAddonInstalled
  • todo: fix tests
  • maybe: clean blender errors which say: "Missing addons"
  • windows only: block addon uninstallation - on windows it causes data loss, on linux/mac soft links are handled correctly from blender 2.8 (source)
    image
  • windows only: block removal of extension repo as it might lead to data loss
    image
  • automatically apply obvious blender defaults

Because of many changes, this PR waits for #172 to complete.

Relevant: #49

@Mateusz-Grzelinski
Fix JacquesLucke#138: avoid creating duplicate link for addon
e6f2f34 
- Capitalize global variables
- Add type hints
@Mateusz-Grzelinski
Rever capitalization of global vars
408442f
@Mateusz-Grzelinski
Support loading from externsion directory
7c62eca
@Mateusz-Grzelinski
Add patch based tests
6866abb
@Mateusz-Grzelinski
Fix tests and compability with python 3.7
bf3d5a4
@Mateusz-Grzelinski
Fix addon reloading
99c7873
@Mateusz-Grzelinski
Fix type hint
869f0df
@Mateusz-Grzelinski
Fix logic for setting up addon links
74f9585
@Mateusz-Grzelinski
Remove comment
3e9e7ee
@Mateusz-Grzelinski
Mock call to sys.path
b7d756d
@Mateusz-Grzelinski
Deduplicate patch calls
f7b4f7e
@Mateusz-Grzelinski
Update comment
a0f99b6
@Mateusz-Grzelinski
Extensions probably does not need sys.path
445778f 
fixes policy violation
@Mateusz-Grzelinski
Remove no longer needed gitignore
750fc41
@Mateusz-Grzelinski
Fix missing directory
469435c 
Fresh installation of blender is not going to have directory created.
@Mateusz-Grzelinski
Fix: prevent type hint from failing older verions of blender
b803c97
@Mateusz-Grzelinski
Merge remote-tracking branch 'refs/remotes/jack/master' into master-n…
c2e4330 
…o-cherry-pick

# Conflicts:
#	pythonFiles/include/blender_vscode/__init__.py
#	pythonFiles/include/blender_vscode/load_addons.py
@Mateusz-Grzelinski
Cover corner case with extension that can be an addon
af8167a 
- you are developing extension in addons directory
- extension has legacy bl_info defined
- do not create a link
@Mateusz-Grzelinski
Fix test and test new edge case
21c4e78
@Mateusz-Grzelinski
Remove link after blender exits
c6ab0fc 
- prevent from various errors from old links
- during blender version upgrade links are copied what breaks them and required manual fix
@Mateusz-Grzelinski
Fix: sys.path was not handled correctly for fresh blender install
bbe0c9e
@Mateusz-Grzelinski
Revert "Remove link after blender exits"
702e4ea 
This reverts commit c6ab0fc
@Mateusz-Grzelinski
Fix tests
25b1454
@Mateusz-Grzelinski
Fix corner cases
ee612fe 
* cleanup old links in limited way
* search for duplicate links already present on file system
@Mateusz-Grzelinski
Merge remote-tracking branch 'refs/remotes/jack/master' into master-c…
3b29b68 
…lean
@Mateusz-Grzelinski
Fix tests
a95d6ee
@Mateusz-Grzelinski
Fix blender 2.8 compatibility
50e1d01 
Small changes to types
@Mateusz-Grzelinski
Update changelog and readme
7377fe1
@Mateusz-Grzelinski
Improve error message
e901876
@Mateusz-Grzelinski
Change ugly text rendering
5e5d0f9
@Mateusz-Grzelinski
Fix blender 2.8 compability
1cc45ad
@Mateusz-Grzelinski
Update README
e958c83
@Mateusz-Grzelinski
Update README
26972be
@Mateusz-Grzelinski
Update README
7a6c1e8
@Mateusz-Grzelinski
Update README
237de93
@Mateusz-Grzelinski
Update README
7c17ca3
@Mateusz-Grzelinski
Resolve junction using windows cmd as fallback method of getting junc…
fee5b4c 
…tion target
@Mateusz-Grzelinski
Fix tests and blender 2.8 compatibility
4e8601b
@Mateusz-Grzelinski
Update readme
4f45939
@Mateusz-Grzelinski
Merge branch 'master' into master
6f0dc8f
@Mateusz-Grzelinski
Merge remote-tracking branch 'refs/remotes/jack/master'
ddfc085 
# Conflicts:
#	CHANGELOG.md
#	pythonFiles/include/blender_vscode/__init__.py
#	pythonFiles/include/blender_vscode/installation.py
@Mateusz-Grzelinski
Silence error on linux
6c62c5e
@Mateusz-Grzelinski
Update changelog
ee18ca1
@Mateusz-Grzelinski
Silence all errors when resolving link
4e6bff7 
It is not critical functionality, it is ok to ignore errors
@Mateusz-Grzelinski
Update README
38e6451
@Mateusz-Grzelinski
Use vscode URI for settings
ef81feb
@Mateusz-Grzelinski
Update README
3d8c665
@Mateusz-Grzelinski
Update README
426d8de
@Mateusz-Grzelinski
Update README
21bb909
@Mateusz-Grzelinski
Copy link
Collaborator Author

wrong base branch, sory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mateusz-Grzelinski