-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure "specialized" definitions reference their "primitive" concepts #3706
Comments
Thank you for creating this issue @samm82. Yes, we need to go through all of our examples and strengthen the concepts. |
It seems that Drasil/code/drasil-example/projectile/lib/Drasil/Projectile/GenDefs.hs Lines 97 to 112 in 8624ac8
|
You are correct that there seems to be a confusion in this example between |
It does make sense to define the 'concept' of |
I noticed during #3702 that the definition of "position vector" doesn't reference "position" at all! Regardless of whether this definition is meant to convey something different (i.e., if the fix is renaming it vs. redefining it), an investigation of how we "build up" concepts should probably be done as part of the work from that meeting. Thoughts?
Drasil/code/drasil-data/lib/Data/Drasil/Concepts/Physics.hs
Lines 137 to 141 in 1ef469d
The text was updated successfully, but these errors were encountered: