Skip to content

Don't fail package installation if binary can't be downloaded/run #31

@koterpillar

Description

@koterpillar

I'd like to have cloudflared as a dependency but manage the installation of the binaries manually from my package's code (by importing install/upgrade/bin). This is to prompt the users who have firewalls and other paranoid configurations to allow downloads from GitHub (or bring their own binaries).

However, currently the package has somewhat confusing behaviour:

  • If the binary fails to download, the installation succeeds (main throws an error which is ignored here).
  • If the binary is downloaded but cannot execute (due to anti-virus-like software), the installation fails because of process.exit here.

Would you accept a PR removing node lib/cloudflared.js -v from the postinstall script so users can manage the installation themselves?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions