Merge pull request #22 from koterpillar/dont-use-shell-to-run

JacobLinCool · web-flow · commit ca105cc5657d · 2024-06-19T16:40:34.000+08:00
Don't use shell to start process
diff --git a/.changeset/five-chairs-study.md b/.changeset/five-chairs-study.md
@@ -0,0 +1,5 @@
+---
+"cloudflared": patch
+---
+
+Don't use shell to start process
diff --git a/src/index.ts b/src/index.ts
@@ -78,7 +78,7 @@ export async function main(): Promise<void> {
         console.log("Installed cloudflared to " + (await install(bin)));
     }
 
-    const sub = spawn(bin, args, { shell: true, stdio: "inherit" });
+    const sub = spawn(bin, args, { stdio: "inherit" });
 
     sub.on("exit", (code) => {
         if (typeof code === "number") {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"cloudflared": patch
 +---
++
 +Don't use shell to start process
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ export async function main(): Promise<void> {`
`78`	`78`	`console.log("Installed cloudflared to " + (await install(bin)));`
`79`	`79`	`}`
`80`	`80`
`81`		`- const sub = spawn(bin, args, { shell: true, stdio: "inherit" });`
	`81`	`+ const sub = spawn(bin, args, { stdio: "inherit" });`
`82`	`82`
`83`	`83`	`sub.on("exit", (code) => {`
`84`	`84`	`if (typeof code === "number") {`