Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making this EJS 2.0.0 compatible #25

Open
straker opened this issue Oct 20, 2016 · 0 comments
Open

Making this EJS 2.0.0 compatible #25

straker opened this issue Oct 20, 2016 · 0 comments

Comments

@straker
Copy link

straker commented Oct 20, 2016

I'd like to make this repo work with EJS 2.0.0. I figured out the changes that would need to happen to make that work so would be more than happy to make a PR.

Would you be interested in supporting EJS 2.0.0? And if so, would you be ok with a breaking change and a major version bump, as well as dropping EJS 1.0.0 support from master? Or if you'd prefer, I can make it support both EJS versions, but it'll basically have to bring back the options.__proto__ magic that EJS 1.0.0 did but that EJS 2.0.0 no longer does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant