Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many bindings #6

Merged
merged 37 commits into from
Feb 6, 2025
Merged

Many bindings #6

merged 37 commits into from
Feb 6, 2025

Conversation

BiPhan4
Copy link
Collaborator

@BiPhan4 BiPhan4 commented Feb 5, 2025 •
edited
Loading

Adding wasm bindings support for post file and buy storage.

@BiPhan4
clean up comments
fdaf52c
@BiPhan4
remove old core
e6b9df2
@BiPhan4
testing: user c tries to add themselves to the white list
a6752c1
@BiPhan4
Make a note re: nil pointer error
0378ea4
@BiPhan4
remove un-needed helper
3dc2a69
@BiPhan4
make security note
e28bd73
@BiPhan4
properly name bindings package and re-build
a93e010
@BiPhan4
test canine_bindings
1dde7d9
@BiPhan4
remove un-needed execute types
5fede42
@BiPhan4
remove un-used imports
e910c3b
@BiPhan4
Only factory can call bindings
6494aa1
@BiPhan4
fix: log bindings addresses after they are made
cfae8b9
@BiPhan4
assign alice and bob bindings to variables
50d8185
@BiPhan4
change 'state' to 'contractState'
4e71a8d
@BiPhan4
add bindings queries
7fcefdf
@BiPhan4
log bindings state to confirm owner
e1081e3
@BiPhan4
user c attempts to by pass factory - 'empty address string error'?
1ed885d
@BiPhan4
fix: retrieve the bindings mappings at the correct point in test
ef40ba1
@BiPhan4
assert error
7b0639f
@BiPhan4
move foundry to sandbox
3bc6812
@BiPhan4
move evm listener to sandbox
8393281
@BiPhan4
move relayer to sandbox
0e839b5
@BiPhan4
fix work space
2c3fe26
@BiPhan4
fix: give query 'no_exports' feature so linker not confused during build
60d1b48
@BiPhan4
use recently published crate
cdcc2c5
@BiPhan4
re-build and test ensuring published crate works
fddc151
@BiPhan4
declare type alias for ExecuteMsg
7ecd229
@BiPhan4
use new artifact name
2ef8c3e
@BiPhan4
Merge branch 'main' into many-bindings
96eb453
@BiPhan4
use local instead of crate
d34f61c
@BiPhan4 BiPhan4 marked this pull request as ready for review February 5, 2025 21:06
slightlyskepticalpotat
slightlyskepticalpotat approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@slightlyskepticalpotat slightlyskepticalpotat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still get dependency issues but the code looks good.

@BiPhan4
Copy link
Collaborator Author

BiPhan4 commented Feb 6, 2025

@slightlyskepticalpotat

Mulberry experiencing dependency issues is peculiar.

As at this PR, the contracts have not imported any new libraries or updated any dependencies.

Should we hold off on merging until you've resolved the dependency issues?

Remember that wasmd sits on top of canine-chain, so the dependency issues could be between mulberry and canine-chain, not mulberry and the wasm files themselves.

@slightlyskepticalpotat
Copy link
Contributor

mulberry works fine with these bindings, I confirmed earlier this morning

previously I was experiencing dependency issues when unit testing this repository in the interchaintest/ folder with the following command go test -v . -run TestWithContractTestSuite -testify.m TestStorageModule

after re-cloning this repo and re-building an image of canine-chain (evm branch), everything is normal and now all tests pass

feel free to merge

@slightlyskepticalpotat
Copy link
Contributor

@BiPhan4 forgot to tag

@BiPhan4 BiPhan4 merged commit e1d328f into main Feb 6, 2025
@BiPhan4 BiPhan4 deleted the many-bindings branch February 6, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slightlyskepticalpotat slightlyskepticalpotat slightlyskepticalpotat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BiPhan4 @slightlyskepticalpotat