Fix for issue 9367 - Consuming menu events on macos when there is a dialogue window present

[vigneshdurairaj]

Fixes #9367

Tasks

Preview Give feedback

We're having trouble rendering your tasklist, it's most likely has one of the following formatting errors:

• indented tasks (i.e. nested tasklist; support for this is coming!)
• an empty task (i.e. - [ ] on a line by itself)
• any empty new lines (before/after the tasklist or in between tasks)
• duplicate issue/pr links
• a draft task exceeds 512 characters

Please check the tasklists documentation for more information. 🔗 Feedback Discussion

Thank you for participating in the Private Beta ❤️

1. [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request to the documentation repository.
2. Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
3. Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

The issue is that when attempting to paste plain text into the dialogue, the paste menu item in the edit menu's action is triggered. Despite our attempts to consume the event in the ExtractBibtexDialog class, the menu item continued to trigger its action. As a workaround, we added a listener in the menu item to address the issue. We thoroughly tested the feature to the best of our knowledge and determined that the workaround does not affect any other operations. We are submitting a pull request and eager to receive feedback on it. We have attached a screenshot demonstrating that the pasted item does not appear in the table. Thank you for your attention to this matter

[Siedlerchr]

Oh that looks great! Need to test that. It's a really annoying bug in javafx

[Siedlerchr]

Works well so far, just found still one

but that's not that much a problem

[Siedlerchr]

Please follow the checklist in the PR and create a changelog entry as well

[vigneshdurairaj]

If I've interpreted this comment accurately, the changelog comment has been addressed, which means this pull request is now ready for review.

Please follow the checklist in the PR and create a changelog entry as well

[Siedlerchr]

Yes looks good Durairaja Vigneshwar ***@***.***> schrieb am Do., 30. März 2023, 21:37:

…

The changelog comment is resolved, shall i make this PR ready for review? — Reply to this email directly, view it on GitHub <#9716 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACOFZBLGEDZ27RWZU7G2XDW6XOHZANCNFSM6AAAAAAWNEVHPM> . You are receiving this because you commented.Message ID: ***@***.***>