Skip to content

Fix drag and drop in entry editor #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2018
Merged

Fix drag and drop in entry editor #4311

merged 1 commit into from
Sep 2, 2018

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Sep 2, 2018 •
edited
Loading

Fixes #4305

Fixes #4087 (comment, same issue described)

consistent with preview panel behavior

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 2, 2018
@Siedlerchr
Copy link
Member Author

As it's a copy and paste of the method handling in the Preview Panel I merge this now

@Siedlerchr Siedlerchr merged commit 2d5908a into master Sep 2, 2018
@tobiasdiez tobiasdiez deleted the fixdraganddropentry branch September 2, 2018 16:34
tobiasdiez
tobiasdiez reviewed Sep 2, 2018
View reviewed changes
src/main/java/org/jabref/gui/entryeditor/EntryEditor.java
this.panel = panel;
this.databaseContext = panel.getBibDatabaseContext();
this.undoManager = panel.getUndoManager();
this.preferences = Objects.requireNonNull(preferences);
this.fileMonitor = fileMonitor;
this.dialogService = dialogService;

fileHandler = new NewDroppedFileHandler(dialogService, databaseContext, externalFileTypes,
Globals.prefs.getFileDirectoryPreferences(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all these globals...(e.g. add the prefs needed to EntryEditorPreferences).

Siedlerchr added a commit that referenced this pull request Sep 5, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into newEntryDialog
ef38692 
* upstream/master:
  Fix that sometimes a white background appeared in the groups panel (#4316)
  Minimal code improvements
  Fix drag and drop in entry editor (#4311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez left review comments

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @tobiasdiez