Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetcher timestamp #3092

Merged
merged 5 commits into from
Aug 10, 2017
Merged

Fetcher timestamp #3092

merged 5 commits into from
Aug 10, 2017

Conversation

stefan-kolb
Copy link
Member

Fixes #3074.

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 10, 2017
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for separating a preference class. I am unsure, whether we introduced static getters. Our current documentation in https://github.com/JabRef/jabref/wiki/Code-Howtos#how-to-work-with-preferences is somewhat shortcoming in that regard. I think, LayoutFormatterPreferences are a good example about our new way to handle preferences.

I think, the only change required is to let JabRefPreferences have a method getTimestampPreferences.

@stefan-kolb
Copy link
Member Author

Ok, I tried to create a own preference class. Not sure if I've done that correctly (as intended at the moment). Should I also replace calls to the preferences inside the General tab?

@tobiasdiez tobiasdiez merged commit 451d829 into master Aug 10, 2017
@tobiasdiez tobiasdiez deleted the fetcher-timestamp branch August 10, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants