-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add support for LibreOffice's default bibliography styles #13050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jabgui/src/main/java/org/jabref/gui/openoffice/ModifyCSLBibliographyTitleDialogView.java
Show resolved
Hide resolved
jablib/src/main/java/org/jabref/logic/openoffice/oocsltext/CSLCitationOOAdapter.java
Show resolved
Hide resolved
HEADING_4("Heading 4"), | ||
BIBLIOGRAPHY_HEADING("Bibliography Heading"), | ||
BIBLIOGRAPHY_1("Bibliography 1"), | ||
TEXT_BODY("Text body"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you read the issue properly? Did you understand the difference between formatting of the bibliography header and the bibliography text?
The PR is blindly copy-pasted (or AI-adapted) without manual testing, screenshots, proper preference settings, etc. |
Also do not mark the mandatory checks blindly. We expect sincerity from contributors - read what you are marking as "done". |
Hi @subhramit Thank you for looking into the PR. I totally understand your frustration. Right now I'm just trying to figure out about the project . I will ping you if I have any questions or once I take the PR out of draft |
Since you are probably a beginner, here are some more hints about the things that are missing:
|
jablib/src/main/java/org/jabref/logic/openoffice/OpenOfficePreferences.java
Show resolved
Hide resolved
jablib/src/main/java/org/jabref/logic/openoffice/OpenOfficePreferences.java
Show resolved
Hide resolved
@trag-bot didn't find any issues in the code! ✅✨ |
Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of |
Co-authored-by: DTT12912 <derictonythomas@gmail.com> Co-authored-by: subhramit <subhramit.bb@live.in> Signed-off-by: subhramit <subhramit.bb@live.in>
Co-authored-by: DTT12912 <derictonythomas@gmail.com> Co-authored-by: subhramit <subhramit.bb@live.in> Signed-off-by: subhramit <subhramit.bb@live.in>
Co-authored-by: DTT12912 <derictonythomas@gmail.com> Co-authored-by: subhramit <subhramit.bb@live.in> Signed-off-by: subhramit <subhramit.bb@live.in>
Closes #13049
This PR adds support for LibreOffice's default bibliography styles in JabRef's LibreOffice integration. The changes include:
Added new bibliography styles:
Updated the UI:
Backend changes:
These changes ensure that JabRef uses LibreOffice's default bibliography styles by default while still allowing users to choose alternative styles if desired.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)