Refactor IoC - A: Extract Entry Editor #12210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calixtus
force-pushed
the
extract-entry-editor
branch
from
fe21d9b to
f247c7c
Compare
subhramit
added
dev: code-quality
# Conflicts: # src/main/java/org/jabref/gui/frame/JabRefFrame.java
|
Related historic PRs:
Side note: I found the PR for the maintable JavaFX migration: #3621 (and #3591) |
|
There can only be one. |
Checked it, would require more refactoring and would overload this pr even more. |
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
src/main/java/org/jabref/gui/entryeditor/fileannotationtab/FulltextSearchResultsTab.java
Show resolved
Hide resolved
# Conflicts: # src/main/java/org/jabref/gui/frame/JabRefFrame.java
calixtus
changed the title
|
@trag-bot didn't find any issues in the code! ✅✨ |
calixtus
added
the
status: ready-for-review
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
approved these changes
Apr 15, 2025
Siedlerchr
approved these changes
Apr 15, 2025
koppor
approved these changes
Apr 15, 2025
2 tasks
krishnagjsForGit
pushed a commit
to krishnagjsForGit/jabref
that referenced
this pull request
May 2, 2025
* Move EntryEditor to JabRefFrame * Make activeTab observable * Accept no tab * Accept no tab in preview * Migrate showBottomPane to property * Show Editor * Fix NPE * Fixed not showing * Fix duplication of tabs and npe on exit * Fix height * Fix menu item * Cleanup and streamline * Fix test * RewriteRun * Dynamize databaseContext * Codestyle and todo * Fix search sync * Changed fixme comment * Fixed runaway process and simplified DirectoryMonitor * Fix PreviewViewer * Dynamized SourceTab * Dynamized FileAnnotationTab * Added todo comment for future rewrite of entry editor * wip * Fix tests * Checkstyle * l10n and GuiTest * CleanUps * more CleanUp --------- Co-authored-by: Carl Christian Snethlage <calixtus@users.noreply.github.com>
krishnagjsForGit
pushed a commit
to krishnagjsForGit/jabref
that referenced
this pull request
May 2, 2025
* Move EntryEditor to JabRefFrame * Make activeTab observable * Accept no tab * Accept no tab in preview * Migrate showBottomPane to property * Show Editor * Fix NPE * Fixed not showing * Fix duplication of tabs and npe on exit * Fix height * Fix menu item * Cleanup and streamline * Fix test * RewriteRun * Dynamize databaseContext * Codestyle and todo * Fix search sync * Changed fixme comment * Fixed runaway process and simplified DirectoryMonitor * Fix PreviewViewer * Dynamized SourceTab * Dynamized FileAnnotationTab * Added todo comment for future rewrite of entry editor * wip * Fix tests * Checkstyle * l10n and GuiTest * CleanUps * more CleanUp --------- Co-authored-by: Carl Christian Snethlage <calixtus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having an instance of the EntryEditor for every LibraryTab - one is enough. One EntryEditor to rule them all, one EntryEditor to find them, one Entryeditor to bring them all and in the bottom of the interface bind them.
Introduced
Todo:
Move Open/Close of EntryEditor to JabRefFrameAdapt EntryEditor to follow observables and to tolerate no entryAdapt StateManager from DatabaseContext to LibraryTab? (invalid)Fix remaining bugs:Not showing anythingNPE on exitOpen entry editor menu itemEntry editor maximized when openExtract refs to library tab from Entry Editorpostponed to later PR, requires refactoring of GlobalSearchBar and activeSearchQuery for sync issues.
Fix issue about lost sync on startupwas present before, postponed to later prGoal:
Level of abstraction (StateManager should use LibraryTab instead of BibDatabaseContext)postponed to later pr. would overload this one
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)