Scrollbar shows up needlessly in group panel, while decreasing the width.

[ThiloteE]

JabRef version

5.5 (latest release)

Operating system

Windows

Details on version and operating system

JabRef 5.6--2022-01-25--2c92eb0 Windows 10 10.0 amd64 Java 16.0.2 JavaFX 17.0.1+1

Checked with the latest development build

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

1. Expand the width of the group panel.
2. Then decrease the width of the groups panel.

Result:

at certain widths, while decreasing the width, the row will show up.

Examples:

• Dark Mode:
  
• Light Mode:
  

Appendix

No response

[ThiloteE]

Desired behaviour: This special row should show in the same colour as the rest of the background.

[ThiloteE]

Ohh, it seems to be the scrollbar!

[Siedlerchr]

Yep, it's the scrollbar. Might be a javafx thing.. Not sure if this changable.

[ThiloteE]

I will leave it open for the sake of acknowledging that it exists, but this issue is definitely low priority. More important issues around.

[LIM0000]

Hi,
I'm interested in working on this issue as my first code contribution to open-source. Can I give it a shot?

[ThiloteE]

This issue possibly already MIGHT have been solved in JFX 18.
See the release notes. There have been multiple fixes to scroll-bars. Following pull request will introduce JFX to JabRef: #8629

In case JFX 18 has NOT fixed this, work probably needs to be done here, instead of at JabRef. Going through the JFX issue list first is advised.

[ThiloteE]

@LIM0000 this issue has low priority and it could be that it will be solved with jfx 18. Please check out issues with the label "good first issue". See here: https://github.com/JabRef/jabref/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22.

[LIM0000]

@ThiloteE Thank you for your quick response.

I have checked both the JFX issue lists and JFX 18 release notes, none of the notes have mentioned the ability to disable scroll bar in TreeTableView that is used to display columns of group panel for Jabref.

I have done some researches and found that TreeTableView has its own built-in scrollpane that causes this issue. By looking into Jabref codebase, this issue could be fixed by adding a style to TreeTableView horizontal scrollbar.

.tree-table-view .scroll-bar:horizontal {
    -fx-opacity: 0;
}

Hope this is helpful.

[ThiloteE]

Well, since you already have done so much research and might have a possible fix, sure go ahead :) Open a pull-request and we will be able to see how it behaves.

As a general advice for newcomers: check out https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md for a start. Also, https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace is a good start. Feel free to ask if you have any questions here on GitHub or also at JabRef's Gitter chat.

Try to open a (draft) pull request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.