Dark theme: Entry table: Header of index without the proper color

[mlep]

JabRef 5.1--2020-08-26--fd5bc52
Linux 4.9.0-13-amd64 amd64
Java 15-ea

• Mandatory: I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

A tiny issue: the header of the index column (with the symbol #) does not follow the color scheme of the dark theme. The symbol is black while it should be gray.
See top left-hand corner:

[vatsal-M]

Our team @ISD14-LNMIIT wants to work on this issue. Please assign this issue to us!
@Siedlerchr

[Siedlerchr]

Thanks for taking this issue! At the same time you could also take a look at #6791 also an issue with the dark theme. Probably some color definitions confused.

For getting started please read through our Contribution guide
Codewise the DarkTheme is located here:
https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/Dark.css

[vatsal-M]

Surely, our team will loook into this issue too

[Gena928]

@Siedlerchr,
if possible, I would like to offer 2 solutions for this issue:

1. Convert column into "field column".
   Column header will change its color as required. But we are loosing a tooltip - "Index". I noticed, that all other columns with text in header do not contain tooltips. So, maybe it's OK.

2. Change column header from "#" into an icon.
   In this case we are not loosing tooltip. Example:

Unfortunately I can't keep the header text "#" AND tooltip at the same time. )))

[Siedlerchr]

@Gena928 Thanks for taking this.
I am actually not that deep into the main table column model. Maybe @calixtus or @tobiasdiez can say more

[tobiasdiez]

Another idea would be to add a style class to the node in https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/maintable/MainTableColumnFactory.java#L132 which sets the right font color.

[Gena928]

@tobiasdiez
thanks for Idea. I found a stylesheet Dark.css and feel like .text-unchanged is what we need.
header.getStyleClass().add("text-unchanged");

Can I create a pull request?

[Siedlerchr]

@Gena928 Sure, go ahead! Another issue with the Dark Theme was reported here, maybe you can also take a look at that #6791

[calixtus]

Are there any examples where "text-unchanged" is also used?

[Gena928]

I found only one more entry in package org.jabref.gui.mergeentries.
Class DiffHighlighting.
Method public static Text forUnchanged(String text)