Submit dialog with Ctrl + Enter

[tobiasdiez]

Is your suggestion for improvement related to a problem? Please describe.
If the user fills out a form, has the focus in a text field and hits Ctrl + Enter then he expects that the dialogs default action is performed (which is usually "OK"). Right now nothing happens.

Describe the solution you'd like
Ctrl + Enter should invoke the dialogs default action in every dialog.

[arunikayadav42]

Can I work on this issue?

[tobiasdiez]

@arunikayadav42 Sure! Also have a look at our contribution guide and feel free to drop by in our developer chat if you have questions!

[amolrbhagwat]

@tobiasdiez Since the last comment was 26 days ago with no follow up, I assume this is not being actively worked on. Is that right?

I checked the behavior which is requested by this issue, and indeed, Ctrl+Enter doesn't trigger the default action/submit on the dialogs. I tested this using the 'Connect to shared database and the Preferences dialogs, both which are JavaFX based. I also noticed that Ctrl+Enter does not work on the Add new file type dialog which is based on Swing.

Is the requirement to have Ctrl+Enter work on both types of dialogs, or just JavaFX since the Swing based ones would be eventually replaced?

Also, this would be my first contribution to the project, is there something I should know about?

[tobiasdiez]

@arunikayadav42 did you already started working on this? I guess, its still up for grabs @amolrbhagwat.
Since we are gradually phasing out the Swing dialogs, there is no need to improve them. Just focus on the JavaFX ones.

[amolrbhagwat]

Not yet, just did some looking around. Can work on it on the weekend. Thanks @tobiasdiez!

[amolrbhagwat]

Can I have this assigned to me?

[Siedlerchr]

You can assign it to yourself I think. We can only assign people from our team at github to an issue

[tobiasdiez]

Thanks to @AlekssGu this is now implemented in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.