Incorrect count entry number

[Ali96kz]

Steps to reproduce the behavior:

1. File -> (New Bibtex library) or (New Biblatex library)
2. Add some entry
   Number of entry will be 0.
   

[AEgit]

Is it always an incorrect number, or does this only happen the first time you assign a item to a new group?

I noticed this behaviour before, but as far as I remember you get the correct numbers of items contained in a group, if you save your database, then close JabRef and then reopen the database in JabRef.

This is still, obviously, a bug, but a less serious one, I guess - it is basically the updating process of the groups panel, that does not work properly (which I think is also responsible for some other issues we see with the groups panel).

[Siedlerchr]

Sometimes the number update if you switch to another db and then back again.

[CaptainDaVinci]

@Siedlerchr However, on switching to another library, group count shows count of previous library.

I am looking into this issue right now, what I have found is that when the database is changed, a new instance of the IntegerProperty hits is created each time [1]. And Text (representing GUI for the number of hits) is being bound to this newly created instance [2], therefore the binding does not prove useful here.

The Text should still be updated with the value of hits anyway, but it turns out that the binding of hits to Text is done before hits is updated. It is because of another binding [3] which internally triggers a callback to ViewModelTreeTableCellFactory.

This results in Text holding previous value of hits and not the current one.

When JabRef starts up there are some initial calls made which havehits initialized to 0, and Text binds to that, until database is changed.

[tobiasdiez]

Thanks for investigating this issue. This is how it is supposed to work:

• Whenever a library get's the focus, convert the group tree to a tree of GroupNodeViewModels.
  

  jabref/src/main/java/org/jabref/gui/groups/GroupTreeView.java

  Lines 108 to 113 in 6c61664

  	EasyBind.map(viewModel.rootGroupProperty(),
  	group -> new RecursiveTreeItem<>(
  	group,
  	GroupNodeViewModel::getChildren,
  	GroupNodeViewModel::expandedProperty,
  	viewModel.filterPredicateProperty())));

• Bind the value of the hit property to the text field
  

  jabref/src/main/java/org/jabref/gui/groups/GroupTreeView.java

  Line 137 in 6c61664

  text.textProperty().bind(group.getHits().asString());

• Whenever there are changes to the library, update the hit count (which should then propagate to the text label through the above binding)
  

  jabref/src/main/java/org/jabref/gui/groups/GroupNodeViewModel.java

  Lines 86 to 87 in 6c61664

  	// Register listener
  	databaseContext.getDatabase().getEntries().addListener(this::onDatabaseChanged);

  
  

  jabref/src/main/java/org/jabref/gui/groups/GroupNodeViewModel.java

  Lines 216 to 218 in 6c61664

  	private void onDatabaseChanged(ListChangeListener.Change<? extends BibEntry> change) {
  	calculateNumberOfMatches();
  	}

So it sound's reasonable that there is a problem with the binding of the text label to the correct hits property.