Fix test for quoted lang messages (#3424)

Author: Patrick Scheibe

src/main/java/org/jabref/gui/EntryTypeDialog.java

@@ -216,7 +216,7 @@ private JPanel createIdFetcherPanel() {
         constraints.fill = GridBagConstraints.NONE;
         jPanel.add(generateButton, constraints);
 
-        jPanel.setBorder(BorderFactory.createTitledBorder(BorderFactory.createEtchedBorder(), Localization.lang("ID-based_entry_generator")));
+        jPanel.setBorder(BorderFactory.createTitledBorder(BorderFactory.createEtchedBorder(), Localization.lang("ID-based entry generator")));
 
         SwingUtilities.invokeLater(() -> idTextField.requestFocus());
 

src/main/java/org/jabref/gui/preftabs/ImportSettingsTab.java

@@ -46,10 +46,10 @@ public ImportSettingsTab(JabRefPreferences prefs) {
 
         setLayout(new BorderLayout());
         FormLayout layout = new FormLayout("1dlu, 8dlu, left:pref, 4dlu, fill:3dlu");
-        radioButtonNoMeta = new JRadioButton(Localization.lang("Create_blank_entry_linking_the_PDF"));
-        radioButtonXmp = new JRadioButton(Localization.lang("Create_entry_based_on_XMP-metadata"));
-        radioButtonPDFcontent = new JRadioButton(Localization.lang("Create_entry_based_on_content"));
-        radioButtononlyAttachPDF = new JRadioButton(Localization.lang("Only_attach_PDF"));
+        radioButtonNoMeta = new JRadioButton(Localization.lang("Create blank entry linking the PDF"));
+        radioButtonXmp = new JRadioButton(Localization.lang("Create entry based on XMP-metadata"));
+        radioButtonPDFcontent = new JRadioButton(Localization.lang("Create entry based on content"));
+        radioButtononlyAttachPDF = new JRadioButton(Localization.lang("Only attach PDF"));
         ButtonGroup bg = new ButtonGroup();
         bg.add(radioButtonNoMeta);
         bg.add(radioButtonXmp);

src/test/java/org/jabref/logic/l10n/LocalizationConsistencyTest.java

@@ -116,6 +116,24 @@ public void keyValueShouldBeEqualForEnglishPropertiesMessages() {
         }
     }
 
+    @Test
+    public void languageKeysShouldNotBeQuotedInFiles() throws IOException {
+        final List<LocalizationEntry> quotedEntries = LocalizationParser
+                .findLocalizationParametersStringsInJavaFiles(LocalizationBundleForTest.LANG)
+                .stream()
+                .filter(key -> key.getKey().contains("_") && key.getKey().equals(new LocalizationKey(key.getKey()).getPropertiesKey()))
+                .collect(Collectors.toList());
+        Assert.assertEquals(
+                "Language keys must not be used quoted in code! Use \"This is a message\" instead of \"This_is_a_message\".\n" +
+                        "Please correct the following entries:\n" +
+                        quotedEntries
+                                .stream()
+                                .map(key -> String.format("\n%s (%s)\n", key.getKey(), key.getPath()))
+                                .collect(Collectors.toList())
+                ,
+                Collections.EMPTY_LIST, quotedEntries);
+    }
+
     @Test
     public void findMissingLocalizationKeys() throws IOException {
         List<LocalizationEntry> missingKeys = LocalizationParser.find(LocalizationBundleForTest.LANG).stream().sorted()
@@ -125,7 +143,7 @@ public void findMissingLocalizationKeys() throws IOException {
                         "1. PASTE THESE INTO THE ENGLISH LANGUAGE FILE\n" +
                         "2. EXECUTE: gradlew localizationUpdate\n" +
                         missingKeys.parallelStream()
-                                .map(key -> String.format("%s=%s", key.getKey(), key.getKey()))
+                                .map(key -> String.format("\n%s=%s\n", key.getKey(), key.getKey()))
                                 .collect(Collectors.toList()),
                 Collections.<LocalizationEntry>emptyList(), missingKeys);
     }