Skip to content

Commit cb1f00f

Browse files
m-peelerkopporLoayGhreeb
authored
Auto-Focus Group on Creation (#11453)
* Auto-Select Newly Created Group When a new group is added, that group will automatically be selected and focused. * Update CHANGELOG.md Updated changelog to reflect updates. * Update CHANGELOG.md Fixed capitalization in changelog Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> * Update src/main/java/org/jabref/gui/StateManager.java Co-authored-by: Loay Ghreeb <52158423+LoayGhreeb@users.noreply.github.com> * Update CHANGELOG.md --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> Co-authored-by: Loay Ghreeb <52158423+LoayGhreeb@users.noreply.github.com>
1 parent 0dffe52 commit cb1f00f

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
1111

1212
### Added
1313

14+
- We made new groups automatically to focus upon creation. [#11449](https://github.com/JabRef/jabref/issues/11449)
15+
1416
### Changed
1517

1618
### Fixed

src/main/java/org/jabref/gui/groups/GroupTreeView.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,10 @@ private void initialize() {
175175
BindingsHelper.bindContentBidirectional(
176176
groupTree.getSelectionModel().getSelectedItems(),
177177
viewModel.selectedGroupsProperty(),
178-
newSelectedGroups -> newSelectedGroups.forEach(this::selectNode),
178+
newSelectedGroups -> {
179+
groupTree.getSelectionModel().clearSelection();
180+
newSelectedGroups.forEach(this::selectNode);
181+
},
179182
this::updateSelection
180183
));
181184

src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,15 +178,15 @@ public void addNewSubgroup(GroupNodeViewModel parent, GroupDialogHeader groupDia
178178
groupDialogHeader));
179179

180180
newGroup.ifPresent(group -> {
181-
parent.addSubgroup(group);
181+
GroupTreeNode newSubgroup = parent.addSubgroup(group);
182+
selectedGroups.setAll(new GroupNodeViewModel(database, stateManager, taskExecutor, newSubgroup, localDragboard, preferences));
182183

183184
// TODO: Add undo
184185
// UndoableAddOrRemoveGroup undo = new UndoableAddOrRemoveGroup(parent, new GroupTreeNodeViewModel(newGroupNode), UndoableAddOrRemoveGroup.ADD_NODE);
185186
// panel.getUndoManager().addEdit(undo);
186187

187188
// TODO: Expand parent to make new group visible
188189
// parent.expand();
189-
190190
dialogService.notify(Localization.lang("Added group \"%0\".", group.getName()));
191191
writeGroupChangesToMetaData();
192192
});

0 commit comments

Comments
 (0)