This repository was archived by the owner on Oct 16, 2024. It is now read-only.
Updates code to terraform 12 and tflinting standards #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garybaines
commented
Jul 14, 2021
garybaines
commented
- Updates code to terraform 12 and tflinting standards
- Adds a minimal terraform version file to the module
- Updates python script to conform to pylint standards
- Adds a CODEOWNERS file for PR approvals set to cloud-engineering
zip_file/versions.tf
Outdated
|
|
||
| required_providers { | ||
| aws = { | ||
| #source = "hashicorp/aws" |
There was a problem hiding this comment.
Yes and no. From terraform 13 onwards the commented out line is required to pass tflinting, but it's not compatible with terraform 12, so it's commented out for now.
There was a problem hiding this comment.
So should we create a version compatible with tf12 without the line, and then a further update for tf13 with the line in?
There was a problem hiding this comment.
That is the option. Go on then, I've pushed it without the comment ;-)
Adds a minimal terraform version file to the module Updates python script to conform to pylint standards Adds a CODEOWNERS file for PR approvals
garybaines
force-pushed
the
gmb/tf12-tidy
branch
from
41682fc to
a68776e
Compare
README updated with usage details |
michael-dickinson-sainsburys
approved these changes
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.