-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
SQL contains ISNULL function in select clause parsing always failed. #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issing copyright.ˆ
…odify field type to boolean for prevent memory consumption by creating object and try assertSqlCanBeParsedAndDeparsed on unit test.
# Conflicts: # src/test/java/net/sf/jsqlparser/expression/mysql/MySqlSqlCalcFoundRowsTest.java
1 similar comment
wumpz
reviewed
May 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Any objections if I squash your commits? What does this visitor do in your test? Why not put the test into SelectTest?
Changes integrated. Sorry but I did not use your PR. |
Hello, it doesn't work with NOT as a prefix: @Test
public void testSqlContainIsNullFunctionShouldBeParsed3() throws JSQLParserException {
assertSqlCanBeParsedAndDeparsed("SELECT name, age FROM person WHERE NOT ISNULL(home, 'earn more money')");
} results in:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some change related with ISNULL in 1.3 version.
I found ISNULL expression now supporting. But ISNULL also can be used sql function in MicroSoft SQL Server.
I fixed it by little change to jjt file.
In my fix ISNULL used to both FUNCTION and EXPRESSION so I'm not sure this is right way or not.
Anyway SQL containing ISNULL function possible to parse and deparse.