Add postgress nested with clause #361
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to get here so late. Please provide only one change per Pr. It makes the review easier. I will do a squashed merge in the end. |
|
The |
|
So this can be closed, right? |
|
Please leave, i will try to salvage the other parts! |
|
Sorry, but this thing is too messy to salvage. I will close it but you can re-submit when there is any serious interest. |
| @@ -1723,6 +1737,9 @@ Expression RegularCondition(): | |||
| | token=<OP_MINORTHANEQUALS> { result = new MinorThanEquals(token.image); } | |||
| | token=<OP_NOTEQUALSSTANDARD> { result = new NotEqualsTo(token.image); } | |||
| | token=<OP_NOTEQUALSBANG> { result = new NotEqualsTo(token.image); } | |||
| | token=<OP_DOUBLEAND> { result = new DoubleAnd(token.image); } | |||
| | token=<OP_CONTAINS> { result = new DoubleAnd(token.image); } | |||
There was a problem hiding this comment.
Why create new DoubleAnd for the tokens OP_CONTAINS or OP_CONTAINEDBY
manticore-projects
added a commit
that referenced
this pull request
Sep 12, 2023
manticore-projects
added a commit
that referenced
this pull request
Sep 12, 2023
- sourced from https://github.com/MathewJoseph31/JSqlParser/tree/add-postgress-nested-WithClause - resolves PR #361 - remove redundant comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested With Clauses, so that they can be of the form
WITH A as (
WITH B AS (
WITH C AS (
.
.
)
)
)
supported by latest DB versions, eg. postgres is not currently supported by the parser