Fix: DESC and EXPLAIN #1933
Merged
Fix: DESC and EXPLAIN #1933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +61,8 @@ public void testValidateBlock() throws JSQLParserException { | |||
| @Test | |||
There was a problem hiding this comment.
Next time please use a Parametrised Test for this. Loops in Tests are an Anti-Pattern because you won't know which one failed. You can lookup the KeywordTests for getting a template.
| @@ -1056,29 +1056,43 @@ PurgeStatement PurgeStatement(): { | |||
|
|
|||
| DescribeStatement Describe(): { | |||
| Table table; | |||
| DescribeStatement stmt = new DescribeStatement(); | |||
There was a problem hiding this comment.
Next time, create the statement at the end only after all tokens have parsed and passed, like:
return new Statement().withX(token.image).withY(token.image);
Its not a hard requirement, but in general Objects should be initialized only when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1931, to support MySQL
{EXPLAIN | DESCRIBE | DESC} tbl_nameit is necessary to use LOOKAHEAD(3), It made
explain01.sqlchange. It seems to be expected?