Skip to content

Commit 9672d76

Browse files
committed
Fix parsing ALTER TABLE ... ADD COLUMNS (...)
The current behaviour fails when it encounters `ADD COLUMNS` and merges everything in the `()` into one string with no whitespace. So `ALTER TABLE catalog.table.name ADD COLUMNS (apples int)` becomes `ALTER TABLE catalog.table.name ADD COLUMNS (applesint)`. This commit adds an understanding of how `ADD COLUMNS` to the grammar.
1 parent be8ff93 commit 9672d76

File tree

3 files changed

+64
-31
lines changed

3 files changed

+64
-31
lines changed

src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ public class AlterExpression implements Serializable {
6060
private String commentText;
6161

6262
private boolean hasColumn = false;
63+
private boolean hasColumns = false;
6364

6465

6566
private boolean useBrackets = false;
@@ -80,6 +81,10 @@ public boolean hasColumn() {
8081
return hasColumn;
8182
}
8283

84+
public boolean hasColumns() {
85+
return hasColumns;
86+
}
87+
8388
public boolean useBrackets() {
8489
return useBrackets;
8590
}
@@ -92,6 +97,10 @@ public void hasColumn(boolean hasColumn) {
9297
this.hasColumn = hasColumn;
9398
}
9499

100+
public void hasColumns(boolean hasColumns) {
101+
this.hasColumns = hasColumns;
102+
}
103+
95104
public String getFkSourceSchema() {
96105
return fkSourceSchema;
97106
}
@@ -503,6 +512,8 @@ public String toString() {
503512
} else {
504513
if (hasColumn) {
505514
b.append("COLUMN ");
515+
} else if (hasColumns) {
516+
b.append("COLUMNS ");
506517
}
507518
if (useIfNotExists
508519
&& operation == AlterOperation.ADD) {

src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt

Lines changed: 37 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1187,7 +1187,7 @@ DescribeStatement Describe(): {
11871187
DescribeStatement stmt = new DescribeStatement();
11881188
Token tk = null;
11891189
} {
1190-
(tk=<K_DESCRIBE> | tk=<K_DESC>)
1190+
(tk=<K_DESCRIBE> | tk=<K_DESC>)
11911191
table = Table() { stmt.setDescribeType(tk.image).setTable(table); }
11921192
{
11931193
return stmt;
@@ -1388,13 +1388,13 @@ Statement RefreshMaterializedView(): {
13881388
}
13891389
{
13901390
<K_REFRESH> <K_MATERIALIZED> <K_VIEW>
1391-
[ LOOKAHEAD(2) <K_CONCURRENTLY> { concurrently = true; } ]
1391+
[ LOOKAHEAD(2) <K_CONCURRENTLY> { concurrently = true; } ]
13921392
view = Table()
13931393
[
13941394
<K_WITH> { refreshMode = RefreshMode.WITH_DATA; }
1395-
[
1395+
[
13961396
<K_NO> { refreshMode = RefreshMode.WITH_NO_DATA; }
1397-
]
1397+
]
13981398
<K_DATA>
13991399
]
14001400
captureRest = captureRest()
@@ -2017,7 +2017,7 @@ The following tokens are allowed as Names for Schema, Table, Column and Aliases
20172017
String RelObjectNameWithoutValue() :
20182018
{ Token tk = null; }
20192019
{
2020-
( tk=<DATA_TYPE> | tk=<S_IDENTIFIER> | tk=<S_QUOTED_IDENTIFIER> | tk=<K_DATE_LITERAL> | tk=<K_DATETIMELITERAL> | tk=<K_STRING_FUNCTION_NAME> | tk=<K_ISOLATION> | tk=<K_TIME_KEY_EXPR> | tk=<K_TEXT_LITERAL>
2020+
( tk=<DATA_TYPE> | tk=<S_IDENTIFIER> | tk=<S_QUOTED_IDENTIFIER> | tk=<K_DATE_LITERAL> | tk=<K_DATETIMELITERAL> | tk=<K_STRING_FUNCTION_NAME> | tk=<K_ISOLATION> | tk=<K_TIME_KEY_EXPR> | tk=<K_TEXT_LITERAL>
20212021
| tk="ACTION" | tk="ACTIVE" | tk="ADD" | tk="ADVANCE" | tk="ADVISE" | tk="AGAINST" | tk="ALGORITHM" | tk="ALTER" | tk="ANALYZE" | tk="APPLY" | tk="APPROXIMATE" | tk="ARCHIVE" | tk="ARRAY" | tk="ASC" | tk="AT" | tk="AUTHORIZATION" | tk="AUTO" | tk="BASE64" | tk="BEGIN" | tk="BERNOULLI" | tk="BINARY" | tk="BIT" | tk="BLOCK" | tk="BROWSE" | tk="BUFFERS" | tk="BY" | tk="BYTE" | tk="BYTES" | tk="CACHE" | tk="CALL" | tk="CASCADE" | tk="CASE" | tk="CAST" | tk="CHANGE" | tk="CHANGES" | tk="CHAR" | tk="CHARACTER" | tk="CHECKPOINT" | tk="CLOSE" | tk="COLLATE" | tk="COLUMN" | tk="COLUMNS" | tk="COMMENT" | tk="COMMIT" | tk="CONCURRENTLY" | tk="CONFLICT" | tk="CONSTRAINTS" | tk="CONVERT" | tk="COSTS" | tk="COUNT" | tk="CS" | tk="CYCLE" | tk="DATA" | tk="DATABASE" | tk="DATETIME" | tk="DBA_RECYCLEBIN" | tk="DDL" | tk="DECLARE" | tk="DEFERRABLE" | tk="DELAYED" | tk="DELETE" | tk="DESC" | tk="DESCRIBE" | tk="DISABLE" | tk="DISCONNECT" | tk="DIV" | tk="DML" | tk="DO" | tk="DOMAIN" | tk="DROP" | tk="DUMP" | tk="DUPLICATE" | tk="ELEMENTS" | tk="EMIT" | tk="ENABLE" | tk="END" | tk="ERROR" | tk="ESCAPE" | tk="EXCLUDE" | tk="EXEC" | tk="EXECUTE" | tk="EXPLAIN" | tk="EXPLICIT" | tk="EXTENDED" | tk="EXTRACT" | tk="FALSE" | tk="FILTER" | tk="FIRST" | tk="FLUSH" | tk="FN" | tk="FOLLOWING" | tk="FORMAT" | tk="FULLTEXT" | tk="FUNCTION" | tk="GRANT" | tk="GROUP_CONCAT" | tk="GUARD" | tk="HASH" | tk="HIGH_PRIORITY" | tk="HISTORY" | tk="HOPPING" | tk="INCLUDE" | tk="INCLUDE_NULL_VALUES" | tk="INCREMENT" | tk="INDEX" | tk="INSERT" | tk="INTERLEAVE" | tk="INTERPRET" | tk="INVALIDATE" | tk="ISNULL" | tk="JSON" | tk="JSON_ARRAY" | tk="JSON_ARRAYAGG" | tk="JSON_OBJECT" | tk="JSON_OBJECTAGG" | tk="KEEP" | tk="KEY" | tk="KEYS" | tk="LAST" | tk="LEADING" | tk="LINK" | tk="LOCAL" | tk="LOCKED" | tk="LOG" | tk="LONGTEXT" | tk="LOOP" | tk="LOW_PRIORITY" | tk="MATCH" | tk="MATCHED" | tk="MATERIALIZED" | tk="MAX" | tk="MAXVALUE" | tk="MEDIUMTEXT" | tk="MEMBER" | tk="MERGE" | tk="MIN" | tk="MINVALUE" | tk="MODIFY" | tk="MOVEMENT" | tk="NEXT" | tk="NO" | tk="NOCACHE" | tk="NOKEEP" | tk="NOLOCK" | tk="NOMAXVALUE" | tk="NOMINVALUE" | tk="NOORDER" | tk="NOTHING" | tk="NOTNULL" | tk="NOVALIDATE" | tk="NOWAIT" | tk="NULLS" | tk="OF" | tk="OFF" | tk="OPEN" | tk="OVER" | tk="OVERFLOW" | tk="OVERLAPS" | tk="PARALLEL" | tk="PARENT" | tk="PARTITION" | tk="PATH" | tk="PERCENT" | tk="PLACING" | tk="PLAN" | tk="PRECEDING" | tk="PRIMARY" | tk="PURGE" | tk="QUERY" | tk="QUICK" | tk="QUIESCE" | tk="RANGE" | tk="RAW" | tk="READ" | tk="RECURSIVE" | tk="RECYCLEBIN" | tk="REFERENCES" | tk="REFRESH" | tk="REGEXP" | tk="REGEXP_LIKE" | tk="REGISTER" | tk="REMOTE" | tk="RENAME" | tk="REPEATABLE" | tk="REPLACE" | tk="RESET" | tk="RESPECT" | tk="RESTART" | tk="RESTRICT" | tk="RESTRICTED" | tk="RESUMABLE" | tk="RESUME" | tk="RETURN" | tk="RLIKE" | tk="ROLLBACK" | tk="ROLLUP" | tk="ROOT" | tk="ROW" | tk="ROWS" | tk="RR" | tk="RS" | tk="SAFE_CAST" | tk="SAVEPOINT" | tk="SCHEMA" | tk="SECURE" | tk="SEED" | tk="SEPARATOR" | tk="SEQUENCE" | tk="SESSION" | tk="SETS" | tk="SHARE" | tk="SHOW" | tk="SHUTDOWN" | tk="SIBLINGS" | tk="SIGNED" | tk="SIMILAR" | tk="SIZE" | tk="SKIP" | tk="STORED" | tk="STRING" | tk="STRUCT" | tk="SUMMARIZE" | tk="SUSPEND" | tk="SWITCH" | tk="SYNONYM" | tk="SYSTEM" | tk="TABLE" | tk="TABLESPACE" | tk="TEMP" | tk="TEMPORARY" | tk="TEXT" | tk="THEN" | tk="TIMEOUT" | tk="TIMESTAMPTZ" | tk="TIMEZONE" | tk="TINYTEXT" | tk="TO" | tk="TRIGGER" | tk="TRUE" | tk="TRUNCATE" | tk="TRY_CAST" | tk="TUMBLING" | tk="TYPE" | tk="UNLOGGED" | tk="UNQIESCE" | tk="UNSIGNED" | tk="UPDATE" | tk="UPSERT" | tk="UR" | tk="USER" | tk="VALIDATE" | tk="VERBOSE" | tk="VIEW" | tk="VOLATILE" | tk="WAIT" | tk="WITHIN" | tk="WITHOUT" | tk="WITHOUT_ARRAY_WRAPPER" | tk="WORK" | tk="XML" | tk="XMLAGG" | tk="XMLDATA" | tk="XMLSCHEMA" | tk="XMLTEXT" | tk="XSINIL" | tk="YAML" | tk="YES" | tk="ZONE" )
20222022
{ return tk.image; }
20232023
}
@@ -2227,7 +2227,7 @@ TableStatement TableStatement():
22272227
List<OrderByElement> orderByElements = null;
22282228
Limit limit = null;
22292229
Offset offset = null;
2230-
TableStatement tableStatement = new TableStatement();
2230+
TableStatement tableStatement = new TableStatement();
22312231
}{
22322232
<K_TABLE>
22332233
table = Table()
@@ -2560,12 +2560,12 @@ PlainSelect PlainSelect() #PlainSelect:
25602560
[ LOOKAHEAD(<K_LIMIT>, { limit==null }) limit = LimitWithOffset() { plainSelect.setLimit(limit); } ]
25612561
[ LOOKAHEAD(<K_FETCH>) fetch = Fetch() { plainSelect.setFetch(fetch); } ]
25622562
[ LOOKAHEAD(<K_WITH> <K_ISOLATION>) withIsolation = WithIsolation() { plainSelect.setIsolation(withIsolation); } ]
2563-
[ LOOKAHEAD(2)
2564-
<K_FOR>
2563+
[ LOOKAHEAD(2)
2564+
<K_FOR>
25652565
(
2566-
<K_UPDATE> { plainSelect.setForMode(ForMode.UPDATE); }
2567-
| <K_SHARE> { plainSelect.setForMode(ForMode.SHARE); }
2568-
| (<K_NO> <K_KEY> <K_UPDATE> { plainSelect.setForMode(ForMode.NO_KEY_UPDATE); })
2566+
<K_UPDATE> { plainSelect.setForMode(ForMode.UPDATE); }
2567+
| <K_SHARE> { plainSelect.setForMode(ForMode.SHARE); }
2568+
| (<K_NO> <K_KEY> <K_UPDATE> { plainSelect.setForMode(ForMode.NO_KEY_UPDATE); })
25692569
| (<K_KEY> <K_SHARE> { plainSelect.setForMode(ForMode.KEY_SHARE); })
25702570
)
25712571
[ LOOKAHEAD(2) <K_OF> updateTable = Table() { plainSelect.setForUpdateTable(updateTable); } ]
@@ -3480,7 +3480,7 @@ GroupByElement GroupByColumnReferences():
34803480
<K_GROUP> <K_BY>
34813481
(
34823482
LOOKAHEAD(2) (
3483-
<K_GROUPING> <K_SETS>
3483+
<K_GROUPING> <K_SETS>
34843484
"("
34853485
list = GroupingSet() { groupBy.addGroupingSet(list); }
34863486
( LOOKAHEAD(2) "," list = GroupingSet() { groupBy.addGroupingSet(list); })*
@@ -3490,7 +3490,7 @@ GroupByElement GroupByColumnReferences():
34903490
(
34913491
list = ExpressionList() { groupBy.setGroupByExpressions(list); }
34923492
(
3493-
LOOKAHEAD(2) <K_GROUPING> <K_SETS>
3493+
LOOKAHEAD(2) <K_GROUPING> <K_SETS>
34943494
"("
34953495
list = GroupingSet() { groupBy.addGroupingSet(list); }
34963496
( LOOKAHEAD(2) "," list = GroupingSet() { groupBy.addGroupingSet(list); })*
@@ -6064,10 +6064,10 @@ CreateIndex CreateIndex():
60646064
)
60656065
|
60666066
(
6067-
[ <K_USING> using=<S_IDENTIFIER> {
6067+
[ <K_USING> using=<S_IDENTIFIER> {
60686068
index.setUsing(using.image);
60696069
createIndex.setIndexTypeBeforeOn(true);
6070-
}
6070+
}
60716071
]
60726072
<K_ON> table=Table()
60736073
)
@@ -6605,8 +6605,8 @@ List<String> CreateViewTailComment():
66056605
if (op != null) {
66066606
result.add(op);
66076607
}
6608-
result.add(tk2.image);
6609-
}
6608+
result.add(tk2.image);
6609+
}
66106610
{ return result;}
66116611
}
66126612

@@ -7071,11 +7071,17 @@ AlterExpression AlterExpression():
70717071
)
70727072
|
70737073
LOOKAHEAD(3) (
7074-
( LOOKAHEAD(2) <K_COLUMN> { alterExp.hasColumn(true); } )?
7074+
( LOOKAHEAD(2)
7075+
(
7076+
<K_COLUMN> { alterExp.hasColumn(true); }
7077+
|
7078+
<K_COLUMNS> { alterExp.hasColumns(true); }
7079+
)
7080+
)?
70757081
[ <K_IF> <K_NOT> <K_EXISTS> { alterExp.setUseIfNotExists(true); } ]
70767082
(
70777083
LOOKAHEAD(4) (
7078-
"("
7084+
"("
70797085
{ alterExp.useBrackets(true);}
70807086
alterExpressionColumnDataType = AlterExpressionColumnDataType() {
70817087
alterExp.addColDataType(alterExpressionColumnDataType);
@@ -7089,22 +7095,22 @@ AlterExpression AlterExpression():
70897095
")"
70907096
)
70917097
|
7092-
LOOKAHEAD(2) alterExpressionColumnDataType = AlterExpressionColumnDataType()
7098+
LOOKAHEAD(2) alterExpressionColumnDataType = AlterExpressionColumnDataType()
70937099
{ alterExp.addColDataType(alterExpressionColumnDataType); }
70947100
|
7095-
LOOKAHEAD(3) alterExpressionColumnDropNotNull = AlterExpressionColumnDropNotNull()
7101+
LOOKAHEAD(3) alterExpressionColumnDropNotNull = AlterExpressionColumnDropNotNull()
70967102
{ alterExp.addColDropNotNull( alterExpressionColumnDropNotNull);}
70977103
|
7098-
alterExpressionColumnDropDefault = AlterExpressionColumnDropDefault()
7104+
alterExpressionColumnDropDefault = AlterExpressionColumnDropDefault()
70997105
{ alterExp.addColDropDefault( alterExpressionColumnDropDefault); }
71007106
)
71017107
)
71027108
|
71037109
(
71047110
"(" alterExpressionColumnDataType = AlterExpressionColumnDataType() { alterExp.addColDataType(alterExpressionColumnDataType); }
7105-
(","
7106-
alterExpressionColumnDataType = AlterExpressionColumnDataType() { alterExp.addColDataType(alterExpressionColumnDataType); }
7107-
)*
7111+
(","
7112+
alterExpressionColumnDataType = AlterExpressionColumnDataType() { alterExp.addColDataType(alterExpressionColumnDataType); }
7113+
)*
71087114
")"
71097115
)
71107116
|
@@ -7156,7 +7162,7 @@ AlterExpression AlterExpression():
71567162
[LOOKAHEAD(2) (<K_ON> (tk=<K_DELETE> | tk=<K_UPDATE>) action = Action()
71577163
{ fkIndex.setReferentialAction(ReferentialAction.Type.from(tk.image), action); }
71587164
)]
7159-
[LOOKAHEAD(2) (<K_ON> (tk=<K_DELETE> | tk=<K_UPDATE>) action = Action()
7165+
[LOOKAHEAD(2) (<K_ON> (tk=<K_DELETE> | tk=<K_UPDATE>) action = Action()
71607166
{ fkIndex.setReferentialAction(ReferentialAction.Type.from(tk.image), action); }
71617167
)]
71627168
constraints=AlterExpressionConstraintState() { alterExp.setConstraints(constraints); }
@@ -7310,18 +7316,18 @@ AlterExpression AlterExpression():
73107316
)
73117317
|
73127318
LOOKAHEAD(2)
7313-
(<K_RENAME> ((<K_INDEX> {alterExp.setOperation(AlterOperation.RENAME_INDEX);}
7314-
| <K_KEY> {alterExp.setOperation(AlterOperation.RENAME_KEY);})
7319+
(<K_RENAME> ((<K_INDEX> {alterExp.setOperation(AlterOperation.RENAME_INDEX);}
7320+
| <K_KEY> {alterExp.setOperation(AlterOperation.RENAME_KEY);})
73157321
| <K_CONSTRAINT> { alterExp.setOperation(AlterOperation.RENAME_CONSTRAINT); }
7316-
)
7322+
)
73177323
(tk=<S_IDENTIFIER> | tk=<S_QUOTED_IDENTIFIER>){
73187324
alterExp.setOldIndex(new Index().withName(tk.image));
7319-
}
7325+
}
73207326
<K_TO>
73217327
(tk2=<S_IDENTIFIER> | tk2=<S_QUOTED_IDENTIFIER>){
73227328
index = new Index().withName(tk2.image);
73237329
alterExp.setIndex(index);
7324-
}
7330+
}
73257331
)
73267332
|
73277333
LOOKAHEAD(2) <K_TRUNCATE> <K_PARTITION> { alterExp.setOperation(AlterOperation.TRUNCATE_PARTITION); } truncatePartitionName = RelObjectName() { alterExp.setTruncatePartitionName(truncatePartitionName); }

src/test/java/net/sf/jsqlparser/statement/alter/AlterTest.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,22 @@ public void testAlterTableAddColumn() throws JSQLParserException {
5454
assertEquals("varchar (255)", colDataTypes.get(0).getColDataType().toString());
5555
}
5656

57+
@Test
58+
public void testAlterTableAddColumnsWhitespace() throws JSQLParserException {
59+
Statement stmt =
60+
CCJSqlParserUtil.parse("ALTER TABLE test_catalog.test20241014.tt ADD COLUMNS (apples string, bees int)");
61+
assertTrue(stmt instanceof Alter);
62+
Alter alter = (Alter) stmt;
63+
assertEquals("test_catalog.test20241014.tt", alter.getTable().getFullyQualifiedName());
64+
AlterExpression alterExp = alter.getAlterExpressions().get(0);
65+
assertNotNull(alterExp);
66+
List<ColumnDataType> colDataTypes = alterExp.getColDataTypeList();
67+
assertEquals("apples", colDataTypes.get(0).getColumnName());
68+
assertEquals("string", colDataTypes.get(0).getColDataType().toString());
69+
assertEquals("bees", colDataTypes.get(1).getColumnName());
70+
assertEquals("int", colDataTypes.get(1).getColDataType().toString());
71+
}
72+
5773
@Test
5874
public void testAlterTableAddColumn_ColumnKeyWordImplicit() throws JSQLParserException {
5975
Statement stmt = CCJSqlParserUtil.parse("ALTER TABLE mytable ADD mycolumn varchar (255)");

0 commit comments

Comments
 (0)