Skip to content

Commit 77f6fb8

Browse files
feat: support mysql with rollup (#1923)
* feat: support mysql with rollup * feat: support mysql with rollup
1 parent aaca058 commit 77f6fb8

File tree

6 files changed

+65
-15
lines changed

6 files changed

+65
-15
lines changed

src/main/java/net/sf/jsqlparser/statement/select/GroupByElement.java

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,22 @@
99
*/
1010
package net.sf.jsqlparser.statement.select;
1111

12-
import net.sf.jsqlparser.expression.Expression;
13-
import net.sf.jsqlparser.expression.operators.relational.ExpressionList;
14-
import net.sf.jsqlparser.expression.operators.relational.ParenthesedExpressionList;
15-
1612
import java.io.Serializable;
1713
import java.util.ArrayList;
1814
import java.util.Arrays;
1915
import java.util.Collection;
2016
import java.util.Collections;
2117
import java.util.List;
2218
import java.util.Optional;
19+
import net.sf.jsqlparser.expression.Expression;
20+
import net.sf.jsqlparser.expression.operators.relational.ExpressionList;
21+
import net.sf.jsqlparser.expression.operators.relational.ParenthesedExpressionList;
2322

2423
public class GroupByElement implements Serializable {
2524
private ExpressionList groupByExpressions = new ExpressionList();
2625
private List<ExpressionList> groupingSets = new ArrayList<>();
26+
// postgres rollup is an ExpressionList
27+
private boolean mysqlWithRollup = false;
2728

2829
public boolean isUsingBrackets() {
2930
return groupByExpressions.isUsingBrackets();
@@ -90,6 +91,10 @@ public String toString() {
9091
b.append(")");
9192
}
9293

94+
if (isMysqlWithRollup()) {
95+
b.append(" WITH ROLLUP");
96+
}
97+
9398
return b.toString();
9499
}
95100

@@ -126,4 +131,13 @@ public GroupByElement addGroupingSets(Collection<? extends Object> groupingSets)
126131
collection.addAll(groupingSets);
127132
return this.withGroupingSets(collection);
128133
}
134+
135+
public boolean isMysqlWithRollup() {
136+
return mysqlWithRollup;
137+
}
138+
139+
public GroupByElement setMysqlWithRollup(boolean mysqlWithRollup) {
140+
this.mysqlWithRollup = mysqlWithRollup;
141+
return this;
142+
}
129143
}

src/main/java/net/sf/jsqlparser/statement/select/OrderByElement.java

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@
99
*/
1010
package net.sf.jsqlparser.statement.select;
1111

12-
import net.sf.jsqlparser.expression.Expression;
13-
1412
import java.io.Serializable;
13+
import net.sf.jsqlparser.expression.Expression;
1514

1615
public class OrderByElement implements Serializable {
1716

@@ -24,6 +23,8 @@ public static NullOrdering from(String ordering) {
2423
}
2524

2625
private Expression expression;
26+
// postgres rollup is an ExpressionList
27+
private boolean mysqlWithRollup = false;
2728
private boolean asc = true;
2829
private boolean ascDescPresent = false;
2930
private NullOrdering nullOrdering;
@@ -79,6 +80,9 @@ public String toString() {
7980
b.append(' ');
8081
b.append(nullOrdering == NullOrdering.NULLS_FIRST ? "NULLS FIRST" : "NULLS LAST");
8182
}
83+
if (isMysqlWithRollup()) {
84+
b.append(" WITH ROLLUP");
85+
}
8286
return b.toString();
8387
}
8488

@@ -106,4 +110,13 @@ public <E extends Expression> E getExpression(Class<E> type) {
106110
return type.cast(getExpression());
107111
}
108112

113+
public boolean isMysqlWithRollup() {
114+
return mysqlWithRollup;
115+
}
116+
117+
public OrderByElement setMysqlWithRollup(boolean mysqlWithRollup) {
118+
this.mysqlWithRollup = mysqlWithRollup;
119+
return this;
120+
}
121+
109122
}

src/main/java/net/sf/jsqlparser/util/deparser/GroupByDeParser.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,9 @@ public void deParse(GroupByElement groupBy) {
4545
}
4646
buffer.append(")");
4747
}
48+
49+
if (groupBy.isMysqlWithRollup()) {
50+
buffer.append(" WITH ROLLUP");
51+
}
4852
}
4953
}

src/main/java/net/sf/jsqlparser/util/deparser/OrderByDeParser.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
import java.util.Iterator;
1313
import java.util.List;
14-
1514
import net.sf.jsqlparser.expression.ExpressionVisitor;
1615
import net.sf.jsqlparser.statement.select.OrderByElement;
1716

@@ -58,9 +57,13 @@ public void deParseElement(OrderByElement orderBy) {
5857
}
5958
if (orderBy.getNullOrdering() != null) {
6059
buffer.append(' ');
61-
buffer.append(orderBy.getNullOrdering() == OrderByElement.NullOrdering.NULLS_FIRST ? "NULLS FIRST"
60+
buffer.append(orderBy.getNullOrdering() == OrderByElement.NullOrdering.NULLS_FIRST
61+
? "NULLS FIRST"
6262
: "NULLS LAST");
6363
}
64+
if (orderBy.isMysqlWithRollup()) {
65+
buffer.append(" WITH ROLLUP");
66+
}
6467
}
6568

6669
void setExpressionVisitor(ExpressionVisitor expressionVisitor) {

src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,7 @@ TOKEN: /* SQL Keywords. prefixed with K_ to avoid name clashes */
383383
| <K_RETURNING: "RETURNING">
384384
| <K_RIGHT:"RIGHT">
385385
| <K_ROLLBACK:"ROLLBACK">
386+
| <K_ROLLUP:"ROLLUP">
386387
| <K_ROOT:"ROOT">
387388
| <K_ROW: "ROW">
388389
| <K_ROWS: "ROWS">
@@ -1802,7 +1803,7 @@ String RelObjectNameWithoutValue() :
18021803
{ Token tk = null; }
18031804
{
18041805
( tk=<S_IDENTIFIER> | tk=<S_QUOTED_IDENTIFIER> | tk=<K_DATE_LITERAL> | tk=<K_DATETIMELITERAL> | tk=<K_STRING_FUNCTION_NAME> | tk=<K_ISOLATION> | tk=<K_TIME_KEY_EXPR>
1805-
| tk="ACTION" | tk="ACTIVE" | tk="ADD" | tk="ADVANCE" | tk="ADVISE" | tk="AGAINST" | tk="ALGORITHM" | tk="ALTER" | tk="ANALYZE" | tk="APPLY" | tk="ARCHIVE" | tk="ARRAY" | tk="ASC" | tk="AT" | tk="AUTHORIZATION" | tk="AUTO" | tk="BEGIN" | tk="BERNOULLI" | tk="BINARY" | tk="BIT" | tk="BLOCK" | tk="BROWSE" | tk="BUFFERS" | tk="BY" | tk="BYTE" | tk="BYTES" | tk="CACHE" | tk="CALL" | tk="CASCADE" | tk="CASE" | tk="CAST" | tk="CHANGE" | tk="CHANGES" | tk="CHAR" | tk="CHARACTER" | tk="CHECKPOINT" | tk="CLOSE" | tk="COLLATE" | tk="COLUMN" | tk="COLUMNS" | tk="COMMENT" | tk="COMMIT" | tk="CONCURRENTLY" | tk="CONFLICT" | tk="CONSTRAINTS" | tk="CONVERT" | tk="COSTS" | tk="CS" | tk="CYCLE" | tk="DATA" | tk="DATABASE" | tk="DDL" | tk="DECLARE" | tk="DEFAULT" | tk="DEFERRABLE" | tk="DELAYED" | tk="DELETE" | tk="DESC" | tk="DESCRIBE" | tk="DISABLE" | tk="DISCONNECT" | tk="DIV" | tk="DML" | tk="DO" | tk="DOMAIN" | tk="DROP" | tk="DUMP" | tk="DUPLICATE" | tk="ELEMENTS" | tk="EMIT" | tk="ENABLE" | tk="END" | tk="ESCAPE" | tk="EXCLUDE" | tk="EXEC" | tk="EXECUTE" | tk="EXPLAIN" | tk="EXPLICIT" | tk="EXTENDED" | tk="EXTRACT" | tk="FALSE" | tk="FILTER" | tk="FIRST" | tk="FLUSH" | tk="FN" | tk="FOLLOWING" | tk="FORMAT" | tk="FULLTEXT" | tk="FUNCTION" | tk="GRANT" | tk="GUARD" | tk="HASH" | tk="HISTORY" | tk="HOPPING" | tk="INCLUDE" | tk="INCREMENT" | tk="INDEX" | tk="INSERT" | tk="INTERLEAVE" | tk="INTERPRET" | tk="INVALIDATE" | tk="ISNULL" | tk="JSON" | tk="KEEP" | tk="KEY" | tk="KEYS" | tk="LAST" | tk="LEADING" | tk="LINK" | tk="LOCAL" | tk="LOCKED" | tk="LOG" | tk="LOOP" | tk="MATCH" | tk="MATCHED" | tk="MATERIALIZED" | tk="MAXVALUE" | tk="MEMBER" | tk="MERGE" | tk="MINVALUE" | tk="MODIFY" | tk="MOVEMENT" | tk="NEXT" | tk="NO" | tk="NOCACHE" | tk="NOKEEP" | tk="NOLOCK" | tk="NOMAXVALUE" | tk="NOMINVALUE" | tk="NOORDER" | tk="NOTHING" | tk="NOTNULL" | tk="NOVALIDATE" | tk="NOWAIT" | tk="NULLS" | tk="OF" | tk="OFF" | tk="OPEN" | tk="OVER" | tk="OVERLAPS" | tk="PARALLEL" | tk="PARENT" | tk="PARTITION" | tk="PATH" | tk="PERCENT" | tk="PLACING" | tk="PRECEDING" | tk="PRECISION" | tk="PRIMARY" | tk="PRIOR" | tk="PURGE" | tk="QUERY" | tk="QUICK" | tk="QUIESCE" | tk="RANGE" | tk="RAW" | tk="READ" | tk="RECYCLEBIN" | tk="REFERENCES" | tk="REFRESH" | tk="REGISTER" | tk="REMOTE" | tk="RENAME" | tk="REPEATABLE" | tk="REPLACE" | tk="RESET" | tk="RESTART" | tk="RESTRICT" | tk="RESTRICTED" | tk="RESUMABLE" | tk="RESUME" | tk="RETURN" | tk="RLIKE" | tk="ROLLBACK" | tk="ROOT" | tk="ROW" | tk="ROWS" | tk="RR" | tk="RS" | tk="SAVEPOINT" | tk="SCHEMA" | tk="SEED" | tk="SEPARATOR" | tk="SEQUENCE" | tk="SESSION" | tk="SETS" | tk="SHARE" | tk="SHOW" | tk="SHUTDOWN" | tk="SIBLINGS" | tk="SIGNED" | tk="SIMILAR" | tk="SIZE" | tk="SKIP" | tk="STORED" | tk="STRING" | tk="SUSPEND" | tk="SWITCH" | tk="SYNONYM" | tk="SYSTEM" | tk="TABLE" | tk="TABLESPACE" | tk="TEMP" | tk="TEMPORARY" | tk="THEN" | tk="TIMEOUT" | tk="TIMESTAMPTZ" | tk="TO" | tk="TRIGGER" | tk="TRUE" | tk="TRUNCATE" | tk="TUMBLING" | tk="TYPE" | tk="UNLOGGED" | tk="UNQIESCE" | tk="UNSIGNED" | tk="UPDATE" | tk="UPSERT" | tk="UR" | tk="USER" | tk="VALIDATE" | tk="VERBOSE" | tk="VIEW" | tk="WAIT" | tk="WITHIN" | tk="WITHOUT" | tk="WORK" | tk="XML" | tk="XMLAGG" | tk="XMLDATA" | tk="XMLSCHEMA" | tk="XMLTEXT" | tk="XSINIL" | tk="YAML" | tk="YES" | tk="ZONE" )
1806+
| tk="ACTION" | tk="ACTIVE" | tk="ADD" | tk="ADVANCE" | tk="ADVISE" | tk="AGAINST" | tk="ALGORITHM" | tk="ALTER" | tk="ANALYZE" | tk="APPLY" | tk="ARCHIVE" | tk="ARRAY" | tk="ASC" | tk="AT" | tk="AUTHORIZATION" | tk="AUTO" | tk="BEGIN" | tk="BERNOULLI" | tk="BINARY" | tk="BIT" | tk="BLOCK" | tk="BROWSE" | tk="BUFFERS" | tk="BY" | tk="BYTE" | tk="BYTES" | tk="CACHE" | tk="CALL" | tk="CASCADE" | tk="CASE" | tk="CAST" | tk="CHANGE" | tk="CHANGES" | tk="CHAR" | tk="CHARACTER" | tk="CHECKPOINT" | tk="CLOSE" | tk="COLLATE" | tk="COLUMN" | tk="COLUMNS" | tk="COMMENT" | tk="COMMIT" | tk="CONCURRENTLY" | tk="CONFLICT" | tk="CONSTRAINTS" | tk="CONVERT" | tk="COSTS" | tk="CS" | tk="CYCLE" | tk="DATA" | tk="DATABASE" | tk="DDL" | tk="DECLARE" | tk="DEFAULT" | tk="DEFERRABLE" | tk="DELAYED" | tk="DELETE" | tk="DESC" | tk="DESCRIBE" | tk="DISABLE" | tk="DISCONNECT" | tk="DIV" | tk="DML" | tk="DO" | tk="DOMAIN" | tk="DROP" | tk="DUMP" | tk="DUPLICATE" | tk="ELEMENTS" | tk="EMIT" | tk="ENABLE" | tk="END" | tk="ESCAPE" | tk="EXCLUDE" | tk="EXEC" | tk="EXECUTE" | tk="EXPLAIN" | tk="EXPLICIT" | tk="EXTENDED" | tk="EXTRACT" | tk="FALSE" | tk="FILTER" | tk="FIRST" | tk="FLUSH" | tk="FN" | tk="FOLLOWING" | tk="FORMAT" | tk="FULLTEXT" | tk="FUNCTION" | tk="GRANT" | tk="GUARD" | tk="HASH" | tk="HISTORY" | tk="HOPPING" | tk="INCLUDE" | tk="INCREMENT" | tk="INDEX" | tk="INSERT" | tk="INTERLEAVE" | tk="INTERPRET" | tk="INVALIDATE" | tk="ISNULL" | tk="JSON" | tk="KEEP" | tk="KEY" | tk="KEYS" | tk="LAST" | tk="LEADING" | tk="LINK" | tk="LOCAL" | tk="LOCKED" | tk="LOG" | tk="LOOP" | tk="MATCH" | tk="MATCHED" | tk="MATERIALIZED" | tk="MAXVALUE" | tk="MEMBER" | tk="MERGE" | tk="MINVALUE" | tk="MODIFY" | tk="MOVEMENT" | tk="NEXT" | tk="NO" | tk="NOCACHE" | tk="NOKEEP" | tk="NOLOCK" | tk="NOMAXVALUE" | tk="NOMINVALUE" | tk="NOORDER" | tk="NOTHING" | tk="NOTNULL" | tk="NOVALIDATE" | tk="NOWAIT" | tk="NULLS" | tk="OF" | tk="OFF" | tk="OPEN" | tk="OVER" | tk="OVERLAPS" | tk="PARALLEL" | tk="PARENT" | tk="PARTITION" | tk="PATH" | tk="PERCENT" | tk="PLACING" | tk="PRECEDING" | tk="PRECISION" | tk="PRIMARY" | tk="PRIOR" | tk="PURGE" | tk="QUERY" | tk="QUICK" | tk="QUIESCE" | tk="RANGE" | tk="RAW" | tk="READ" | tk="RECYCLEBIN" | tk="REFERENCES" | tk="REFRESH" | tk="REGISTER" | tk="REMOTE" | tk="RENAME" | tk="REPEATABLE" | tk="REPLACE" | tk="RESET" | tk="RESTART" | tk="RESTRICT" | tk="RESTRICTED" | tk="RESUMABLE" | tk="RESUME" | tk="RETURN" | tk="RLIKE" | tk="ROLLBACK" | tk="ROLLUP" | tk="ROOT" | tk="ROW" | tk="ROWS" | tk="RR" | tk="RS" | tk="SAVEPOINT" | tk="SCHEMA" | tk="SEED" | tk="SEPARATOR" | tk="SEQUENCE" | tk="SESSION" | tk="SETS" | tk="SHARE" | tk="SHOW" | tk="SHUTDOWN" | tk="SIBLINGS" | tk="SIGNED" | tk="SIMILAR" | tk="SIZE" | tk="SKIP" | tk="STORED" | tk="STRING" | tk="SUSPEND" | tk="SWITCH" | tk="SYNONYM" | tk="SYSTEM" | tk="TABLE" | tk="TABLESPACE" | tk="TEMP" | tk="TEMPORARY" | tk="THEN" | tk="TIMEOUT" | tk="TIMESTAMPTZ" | tk="TO" | tk="TRIGGER" | tk="TRUE" | tk="TRUNCATE" | tk="TUMBLING" | tk="TYPE" | tk="UNLOGGED" | tk="UNQIESCE" | tk="UNSIGNED" | tk="UPDATE" | tk="UPSERT" | tk="UR" | tk="USER" | tk="VALIDATE" | tk="VERBOSE" | tk="VIEW" | tk="WAIT" | tk="WITHIN" | tk="WITHOUT" | tk="WORK" | tk="XML" | tk="XMLAGG" | tk="XMLDATA" | tk="XMLSCHEMA" | tk="XMLTEXT" | tk="XSINIL" | tk="YAML" | tk="YES" | tk="ZONE" )
18061807
{ return tk.image; }
18071808
}
18081809

@@ -2984,20 +2985,23 @@ GroupByElement GroupByColumnReferences():
29842985
<K_GROUP> <K_BY>
29852986
(
29862987
LOOKAHEAD(2) (
2987-
<K_GROUPING> <K_SETS> "("
2988-
list = GroupingSet() { groupBy.addGroupingSet(list); }
2989-
( LOOKAHEAD(2) "," list = GroupingSet() { groupBy.addGroupingSet(list); })*
2988+
<K_GROUPING> <K_SETS>
2989+
"("
2990+
list = GroupingSet() { groupBy.addGroupingSet(list); }
2991+
( LOOKAHEAD(2) "," list = GroupingSet() { groupBy.addGroupingSet(list); })*
29902992
")"
29912993
)
29922994
|
29932995
(
29942996
list = ExpressionList() { groupBy.setGroupByExpressions(list); }
29952997
(
2996-
LOOKAHEAD(2) <K_GROUPING> <K_SETS> "("
2997-
list = GroupingSet() { groupBy.addGroupingSet(list); }
2998-
( LOOKAHEAD(2) "," list = GroupingSet() { groupBy.addGroupingSet(list); })*
2998+
LOOKAHEAD(2) <K_GROUPING> <K_SETS>
2999+
"("
3000+
list = GroupingSet() { groupBy.addGroupingSet(list); }
3001+
( LOOKAHEAD(2) "," list = GroupingSet() { groupBy.addGroupingSet(list); })*
29993002
")"
30003003
)?
3004+
[ LOOKAHEAD(2) <K_WITH> <K_ROLLUP> { groupBy.setMysqlWithRollup(true); } ]
30013005
)
30023006
)
30033007
{
@@ -3072,6 +3076,7 @@ OrderByElement OrderByElement():
30723076
)
30733077
]
30743078
]
3079+
[ LOOKAHEAD(2) <K_WITH> <K_ROLLUP> { orderByElement.setMysqlWithRollup(true); } ]
30753080
{
30763081
orderByElement.setExpression(columnReference);
30773082
return orderByElement;

src/test/java/net/sf/jsqlparser/statement/select/SelectTest.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5795,4 +5795,15 @@ void testBackSlashQuotationIssue1812() throws JSQLParserException {
57955795
sqlStr, parser -> parser
57965796
.withBackslashEscapeCharacter(true));
57975797
}
5798+
5799+
@Test
5800+
public void testIssue1907() throws JSQLParserException {
5801+
String stmt = "SELECT MAX(a, b, c), COUNT(*), D FROM tab1 GROUP BY D WITH ROLLUP";
5802+
assertSqlCanBeParsedAndDeparsed(stmt);
5803+
5804+
// since mysql 8.0.12
5805+
String stmt2 =
5806+
"SELECT * FROM (SELECT year, person, SUM(amount) FROM rentals GROUP BY year, person) t1 ORDER BY year DESC WITH ROLLUP";
5807+
assertSqlCanBeParsedAndDeparsed(stmt2);
5808+
}
57985809
}

0 commit comments

Comments
 (0)