Skip to content

Commit 11616a0

Browse files
authored
chore removing system.out.println lines + minor clean up of unit test scripts (#2060)
* chore removing system.out.println lines + minor clean up * formatting fixes via spotlessApply
1 parent 82470e5 commit 11616a0

File tree

4 files changed

+12
-23
lines changed

4 files changed

+12
-23
lines changed

src/test/java/net/sf/jsqlparser/statement/StatementSeparatorTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ void testNewLineNotGoIssue() throws JSQLParserException {
5353
void testOracleBlock() throws JSQLParserException {
5454
String sqlStr = "BEGIN\n" + "\n" + "SELECT * FROM TABLE;\n" + "\n" + "END\n" + "/\n";
5555
Statement statement = TestUtils.assertSqlCanBeParsedAndDeparsed(sqlStr, true);
56-
System.out.println(statement);
5756
}
5857

5958
@Test
@@ -69,14 +68,12 @@ void testSOQLIncludes() throws JSQLParserException {
6968
String sqlStr =
7069
"select name,\ngoods from test_table where option includes ('option1', 'option2')";
7170
Statement statement = TestUtils.assertSqlCanBeParsedAndDeparsed(sqlStr, true);
72-
System.out.println(statement);
7371
}
7472

7573
@Test
7674
void testSOQLExcludes() throws JSQLParserException {
7775
String sqlStr =
7876
"select name,\ngoods from test_table where option excludes ('option1', 'option2')";
7977
Statement statement = TestUtils.assertSqlCanBeParsedAndDeparsed(sqlStr, true);
80-
System.out.println(statement);
8178
}
8279
}

src/test/java/net/sf/jsqlparser/statement/alter/AlterTest.java

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,15 +71,14 @@ public void testAlterTableAddColumn_ColumnKeyWordImplicit() throws JSQLParserExc
7171
@Test
7272
public void testAlterTableBackBrackets() throws JSQLParserException {
7373
String sql = "ALTER TABLE tablename add column (field string comment 'aaaaa')";
74-
Statement statement = CCJSqlParserUtil.parse(sql);
75-
Alter alter = (Alter) statement;
76-
System.out.println(alter.toString());
74+
Alter alter = (Alter) assertSqlCanBeParsedAndDeparsed(sql);
75+
assertEquals("tablename", alter.getTable().toString());
7776

7877
String sql2 =
7978
"ALTER TABLE tablename add column (field string comment 'aaaaa', field2 string comment 'bbbbb');";
8079
Statement statement2 = CCJSqlParserUtil.parse(sql2);
8180
Alter alter2 = (Alter) statement2;
82-
System.out.println(alter2.toString());
81+
assertEquals("tablename", alter2.getTable().toString());
8382
}
8483

8584

@@ -1025,20 +1024,24 @@ public void testIssue1875() throws JSQLParserException {
10251024
}
10261025

10271026
@Test
1028-
public void testIssue2027() throws JSQLParserException{
1027+
public void testIssue2027() throws JSQLParserException {
10291028
String sql = "ALTER TABLE `foo_bar` ADD COLUMN `baz` text";
10301029
assertSqlCanBeParsedAndDeparsed(sql);
10311030

1032-
String sqlText = "ALTER TABLE `foo_bar` ADD COLUMN `baz` text CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NULL";
1031+
String sqlText =
1032+
"ALTER TABLE `foo_bar` ADD COLUMN `baz` text CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NULL";
10331033
assertSqlCanBeParsedAndDeparsed(sqlText);
10341034

1035-
String sqlTinyText = "ALTER TABLE `foo_bar` ADD COLUMN `baz` tinytext CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NULL";
1035+
String sqlTinyText =
1036+
"ALTER TABLE `foo_bar` ADD COLUMN `baz` tinytext CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NULL";
10361037
assertSqlCanBeParsedAndDeparsed(sqlTinyText);
10371038

1038-
String sqlMediumText = "ALTER TABLE `foo_bar` ADD COLUMN `baz` mediumtext CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NULL";
1039+
String sqlMediumText =
1040+
"ALTER TABLE `foo_bar` ADD COLUMN `baz` mediumtext CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NULL";
10391041
assertSqlCanBeParsedAndDeparsed(sqlMediumText);
10401042

1041-
String sqlLongText = "ALTER TABLE `foo_bar` ADD COLUMN `baz` longtext CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NULL";
1043+
String sqlLongText =
1044+
"ALTER TABLE `foo_bar` ADD COLUMN `baz` longtext CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NULL";
10421045
assertSqlCanBeParsedAndDeparsed(sqlLongText);
10431046
}
10441047
}

src/test/java/net/sf/jsqlparser/statement/merge/MergeTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,6 @@ public void testOracleMergeIntoStatement() throws JSQLParserException {
4242
+ " INSERT (B.employee_id, B.bonus)\n"
4343
+ " VALUES (E.employee_id, E.salary * 0.05) ";
4444

45-
Statement statement = CCJSqlParserUtil.parse(sql);
46-
47-
System.out.println(statement.toString());
48-
4945
assertSqlCanBeParsedAndDeparsed(sql, true);
5046
}
5147

src/test/java/net/sf/jsqlparser/statement/select/SelectTest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4539,13 +4539,6 @@ public void testLongQualifiedNamesIssue763() throws JSQLParserException {
45394539
"SELECT mongodb.test.test.intField, postgres.test.test.intField, postgres.test.test.datefield FROM mongodb.test.test JOIN postgres.postgres.test.test ON mongodb.test.test.intField = postgres.test.test.intField WHERE mongodb.test.test.intField = 123");
45404540
}
45414541

4542-
@Test
4543-
public void testLongQualifiedNamesIssue763_2() throws JSQLParserException {
4544-
Statement parse = CCJSqlParserUtil.parse(new StringReader(
4545-
"SELECT mongodb.test.test.intField, postgres.test.test.intField, postgres.test.test.datefield FROM mongodb.test.test JOIN postgres.postgres.test.test ON mongodb.test.test.intField = postgres.test.test.intField WHERE mongodb.test.test.intField = 123"));
4546-
System.out.println(parse.toString());
4547-
}
4548-
45494542
@Test
45504543
public void testSubQueryAliasIssue754() throws JSQLParserException {
45514544
assertSqlCanBeParsedAndDeparsed(

0 commit comments

Comments
 (0)