Skip to content

Conversation

aichbauer
Copy link
Collaborator

changed

  • initial-commit -> initialCommit
  • min-char -> minChar
  • max-char -> maxChar
  • end-with-dot -> endWithDot

This would be be a breaking change because if someone uses a .sgcrc file for a project it would not work any more.

@aichbauer aichbauer requested a review from JPeer264 November 14, 2017 21:57
@coveralls
Copy link

coveralls commented Nov 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling df34e1e on fix/sameStyle into fbb1981 on master.

Copy link
Owner

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Nov 21, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 4f9155e on fix/sameStyle into 540af59 on master.

@JPeer264 JPeer264 merged commit 866cffd into master Dec 5, 2017
@JPeer264 JPeer264 deleted the fix/sameStyle branch December 5, 2017 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants