Integration with Movie Workbench #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the position of importing the Movie Workbench
Simple corrections
|
Hopefully @JMG1 is still active |
|
@JMG1 ping |
|
@JMG1 ping |
|
For clarifications: The idea of the connection module is so that other animation workbenches can move cameras, record videos from the 3D window or from renderings that the Movie and Render workbenches offer. And yes, it is optional, but the connection is not made only with the Movie Wokbench installed, this can still cause inconvenience. Thus, this connection is only triggered when necessary and activated by def connectionMC(option = True). |
|
It's been almost a year since I submitted this PR. Are there any objections or adaptations needed for it? Is it normal for a request to remain open without a response for an indefinite period of time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptation made to be able to work together with the Movie Workbench that allows recording videos of animations.
https://github.com/Francisco-Rosa/FreeCAD-Movie
See too: https://forum.freecadweb.org/viewtopic. ... 82#p647382