Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Commit 418bebf

Browse files
committed
Disconnect resize observer before destroying component
1 parent 2e18679 commit 418bebf

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

src/listscroller.vue

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,5 +298,9 @@ export default {
298298
this.observer = new ResizeObserver(this.onItemsResize)
299299
this.setStart(0)
300300
},
301+
302+
beforeDestroy() {
303+
this.observer.disconnect()
304+
},
301305
}
302306
</script>

tests/listscroller.test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ describe('ListScroller component', () => {
9999
'resize',
100100
window.addEventListener.mock.calls[1][1],
101101
)
102+
expect(ResizeObserver.mock.instances[0].disconnect).toBeCalledTimes(1)
102103
})
103104

104105
it('passes data and index to item component', () => {

tests/resizeobserver.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
export default class ResizeObserver {
22
observe() {}
33
unobserve() {}
4+
disconnect() {}
45
}

0 commit comments

Comments
 (0)