Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies: ES5 Compat #192

Closed
ItsJonQ opened this issue Dec 10, 2020 · 3 comments
Closed

Dependencies: ES5 Compat #192

ItsJonQ opened this issue Dec 10, 2020 · 3 comments
Assignees
@ItsJonQ
Labels
dependencies Pull requests that update a dependency file

Comments

@ItsJonQ
Copy link
Owner

ItsJonQ commented Dec 10, 2020

An E2E test in Gutenberg is failing as something from the deps. is providing code using const.
Need to investigate to resolve this

WordPress/gutenberg#27594 (comment)
@ItsJonQ ItsJonQ added the dependencies Pull requests that update a dependency file label Dec 10, 2020
@ItsJonQ ItsJonQ self-assigned this Dec 10, 2020
@ItsJonQ
Copy link
Owner Author

ItsJonQ commented Dec 10, 2020

Investigated. Not too sure what's up with the dependencies (yet)

WordPress/gutenberg#27594 (comment)

@ItsJonQ
Copy link
Owner Author

ItsJonQ commented Jan 11, 2021

It looks like zustand is causing babel/webpack issues for the Gutenberg repository.

Since we'll be using zustand, I think it'll be good to fork it by copying/pasting the library.

@ItsJonQ
Copy link
Owner Author

ItsJonQ commented Jan 20, 2021

Resolved with zustand refactor

@ItsJonQ ItsJonQ closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ItsJonQ ItsJonQ

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ItsJonQ