-
Notifications
You must be signed in to change notification settings - Fork 40
[MOB-12247] remove-dependency-on-react-native-vector-icons #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOB-12247] remove-dependency-on-react-native-vector-icons #760
Conversation
…leInboxMessageDisplay
|
Diff Coverage: The code coverage on the diff in this pull request is 100.0%. Total Coverage: This PR will increase coverage by 0.74%. File Coverage Changes
🛟 Help
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the react-native-vector-icons dependency from the SDK to address multiple integration issues. The dependency was only used for displaying a chevron icon on the inbox message details page.
Key changes:
- Replaced the vector icon with a custom
HeaderBackButtoncomponent using base64-encoded images - Updated the example app to use base64-encoded icons for tab navigation
- Removed all references to
react-native-vector-iconsfrom package dependencies and documentation
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/inbox/components/IterableInboxMessageDisplay.tsx | Replaced vector icon implementation with new HeaderBackButton component |
| src/inbox/components/HeaderBackButton.tsx | New component that renders a back button with customizable image using base64 encoding |
| src/inbox/components/HeaderBackButton.test.tsx | Comprehensive test suite for the new HeaderBackButton component |
| package.json | Removed react-native-vector-icons from dependencies and peer dependencies |
| example/src/components/App/Main.tsx | Added type assertion for route icon lookup |
| example/src/components/App/App.utils.tsx | Replaced vector icon rendering with Image component using base64 URIs |
| example/src/components/App/App.constants.ts | Added base64-encoded icon data for tab navigation icons |
| example/package.json | Removed react-native-vector-icons dependency from example app |
| example/android/app/build.gradle | Removed vector icons font gradle configuration |
| README.md | Removed react-native-vector-icons from peer dependencies list |
| .eslintrc.js | Added ignore patterns for generated directories |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Ayyanchira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good we have our own component
🔹 JIRA Ticket(s) if any
✏️ Description
Remove
react-native-vector-iconsdependency. All it was being used for was the chevron on our message details page.Issues
Screenshots
Android
iOS