Skip to content

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Oct 15, 2025

🔹 JIRA Ticket(s) if any

✏️ Description

Remove react-native-vector-icons dependency. All it was being used for was the chevron on our message details page.

Issues

Screenshots

Android

Screenshot 2025-10-15 at 2 19 15 PM

iOS

Screenshot_1760563156

@lposen lposen added the dependencies Pull requests that update a dependency file, or issues which involve a fix/change to a dependency label Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Lines Statements Branches Functions
Coverage: 49%
49.47% (237/479) 23.28% (44/189) 41.66% (65/156)

@qltysh
Copy link

qltysh bot commented Oct 15, 2025

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 0.74%.

File Coverage Changes
Path File Coverage Δ Indirect
src/inbox/components/HeaderBackButton.tsx 100.0
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@lposen lposen requested a review from Copilot October 15, 2025 21:29
@lposen lposen self-assigned this Oct 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the react-native-vector-icons dependency from the SDK to address multiple integration issues. The dependency was only used for displaying a chevron icon on the inbox message details page.

Key changes:

  • Replaced the vector icon with a custom HeaderBackButton component using base64-encoded images
  • Updated the example app to use base64-encoded icons for tab navigation
  • Removed all references to react-native-vector-icons from package dependencies and documentation

Reviewed Changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/inbox/components/IterableInboxMessageDisplay.tsx Replaced vector icon implementation with new HeaderBackButton component
src/inbox/components/HeaderBackButton.tsx New component that renders a back button with customizable image using base64 encoding
src/inbox/components/HeaderBackButton.test.tsx Comprehensive test suite for the new HeaderBackButton component
package.json Removed react-native-vector-icons from dependencies and peer dependencies
example/src/components/App/Main.tsx Added type assertion for route icon lookup
example/src/components/App/App.utils.tsx Replaced vector icon rendering with Image component using base64 URIs
example/src/components/App/App.constants.ts Added base64-encoded icon data for tab navigation icons
example/package.json Removed react-native-vector-icons dependency from example app
example/android/app/build.gradle Removed vector icons font gradle configuration
README.md Removed react-native-vector-icons from peer dependencies list
.eslintrc.js Added ignore patterns for generated directories

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good we have our own component

@lposen lposen merged commit 6614c24 into master Oct 16, 2025
13 of 14 checks passed
@lposen lposen deleted the MOB-12247-remove-dependency-on-react-native-vector-icons branch October 16, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file, or issues which involve a fix/change to a dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants