[MOB-11826] make-frontend-api-and-codegen #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ 2 blocking issues (3 total)
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -0,0 +1,140 @@ | |||
| import type { TurboModule } from 'react-native'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,6 @@ | |||
| import { NativeModules } from 'react-native'; | |||
There was a problem hiding this comment.
Comment on lines
860
to
866
| static updateSubscriptions( | ||
| emailListIds: number[] | undefined, | ||
| unsubscribedChannelIds: number[] | undefined, | ||
| unsubscribedMessageTypeIds: number[] | undefined, | ||
| subscribedMessageTypeIds: number[] | undefined, | ||
| emailListIds: number[] | null, | ||
| unsubscribedChannelIds: number[] | null, | ||
| unsubscribedMessageTypeIds: number[] | null, | ||
| subscribedMessageTypeIds: number[] | null, | ||
| campaignId: number, | ||
| templateId: number |
| @@ -0,0 +1,140 @@ | |||
| import type { TurboModule } from 'react-native'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,6 @@ | |||
| import { NativeModules } from 'react-native'; | |||
There was a problem hiding this comment.
Comment on lines
860
to
866
| static updateSubscriptions( | ||
| emailListIds: number[] | undefined, | ||
| unsubscribedChannelIds: number[] | undefined, | ||
| unsubscribedMessageTypeIds: number[] | undefined, | ||
| subscribedMessageTypeIds: number[] | undefined, | ||
| emailListIds: number[] | null, | ||
| unsubscribedChannelIds: number[] | null, | ||
| unsubscribedMessageTypeIds: number[] | null, | ||
| subscribedMessageTypeIds: number[] | null, | ||
| campaignId: number, | ||
| templateId: number |
evantk91
reviewed
Aug 12, 2025
| @@ -0,0 +1,6 @@ | |||
| import { NativeModules } from 'react-native'; | |||
| import BridgelessModule from './NativeRNIterableAPI'; | |||
Contributor
There was a problem hiding this comment.
Not sure where the BridgelessModule specifically comes from.
evantk91
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description
Created the frontend code necessary to run the iOS code with RN new arch.
This was done to separately reduce an enormous PR, so new arch will temporarily not work.
Testing
Building the iOS version of this app in legacy arch should work
ENV['RCT_NEW_ARCH_ENABLED'] = '1'toENV['RCT_NEW_ARCH_ENABLED'] = '0'bundle exec pod deintegraterm -rf ~/Library/Developer/Xcode/DerivedData Pods Podfile.lock build ../Gemfile.lockbundle installbundle exec pod installwatchman watch-del-allyarn start --reset-cacheThe app should build and load correctly