Skip to content

Commit 10c25ae

Browse files
authored
Merge pull request #838 from Iterable/evan/MOB-10109-update-merge-tests
[MOB-10098] fixes update user bug
2 parents f7cce92 + 83a807f commit 10c25ae

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

iterableapi/src/main/java/com/iterable/iterableapi/AnonymousUserManager.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,10 @@ private void createAnonymousUser(String criteriaId) {
207207
try {
208208
if (!userData.isEmpty()) {
209209
JSONObject updateUserObj = getUserUpdateObjFromLocalStorage();
210-
JSONObject updateUserDataFields = updateUserObj.getJSONObject(IterableConstants.KEY_DATA_FIELDS);
211-
210+
JSONObject updateUserDataFields = null;
211+
if (updateUserObj.has(IterableConstants.KEY_DATA_FIELDS)) {
212+
updateUserDataFields = updateUserObj.getJSONObject(IterableConstants.KEY_DATA_FIELDS);
213+
}
212214
JSONObject userSessionDataJson = new JSONObject(userData);
213215
JSONObject userDataJson = userSessionDataJson.getJSONObject(IterableConstants.SHARED_PREFS_ANON_SESSIONS);
214216

iterableapi/src/test/java/com/iterable/iterableapi/IterableApiMergeUserEmailTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ public void testCriteriaNotMetUserIdReplayFalseMergeFalse() throws Exception {
239239
shadowOf(getMainLooper()).idle();
240240
assertNotEquals(("/" + IterableConstants.ENDPOINT_MERGE_USER), mergeRequest.getPath());
241241
assertEquals(userId, IterableApi.getInstance().getUserId());
242-
assertEquals(eventData, getEventData());
242+
assertEquals("", getEventData());
243243
}
244244

245245
@Test
@@ -261,7 +261,7 @@ public void testCriteriaNotMetUserIdReplayFalseMergeTrue() throws Exception {
261261
shadowOf(getMainLooper()).idle();
262262
assertNotEquals(("/" + IterableConstants.ENDPOINT_MERGE_USER), mergeRequest.getPath());
263263
assertEquals(userId, IterableApi.getInstance().getUserId());
264-
assertEquals(eventData, getEventData());
264+
assertEquals("", getEventData());
265265
}
266266

267267
@Test
@@ -401,7 +401,7 @@ public void testCriteriaNotMetEmailMergeFalse() throws Exception {
401401
shadowOf(getMainLooper()).idle();
402402
assertNotEquals(("/" + IterableConstants.ENDPOINT_MERGE_USER), mergeRequest.getPath());
403403
assertEquals(email, IterableApi.getInstance().getEmail());
404-
assertEquals(eventData, getEventData());
404+
assertEquals("", getEventData());
405405
}
406406

407407
@Test
@@ -484,7 +484,7 @@ public void testCriteriaNotMetEmailReplayFalseMergeFalse() throws Exception {
484484
shadowOf(getMainLooper()).idle();
485485
assertNotEquals(("/" + IterableConstants.ENDPOINT_MERGE_USER), mergeRequest.getPath());
486486
assertEquals(email, IterableApi.getInstance().getEmail());
487-
assertEquals(eventData, getEventData());
487+
assertEquals("", getEventData());
488488
}
489489

490490
@Test
@@ -506,7 +506,7 @@ public void testCriteriaNotMetEmailReplayFalseMergeTrue() throws Exception {
506506
shadowOf(getMainLooper()).idle();
507507
assertNotEquals(("/" + IterableConstants.ENDPOINT_MERGE_USER), mergeRequest.getPath());
508508
assertEquals(email, IterableApi.getInstance().getEmail());
509-
assertEquals(eventData, getEventData());
509+
assertEquals("", getEventData());
510510
}
511511

512512
@Test

0 commit comments

Comments
 (0)