Add accessibility.md #1384
Merged
Add accessibility.md #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosiel
approved these changes
Dec 8, 2019
rosiel
reviewed
Dec 8, 2019
| @@ -0,0 +1,3 @@ | |||
| Islandora 8 leans heavily on Drupal for accessibility. Drupal 8 core comes with a number of features to support greater accessibility for developers, site builders, and end users, as outlined [here](https://www.drupal.org/docs/8/accessibility/drupal-8-accessibility-features). This can be extended further with contributed modules, as outlined [here](https://www.drupal.org/docs/8/accessibility/contributed-modules-for-extending-accessibility-in-drupal-8) | |||
There was a problem hiding this comment.
I like that we are putting this in here and don't want to block it. However, I think rephrasing to avoid using the word "here" as link text may be advisable by said accessibility guidelines. For example:
Islandora 8's accessibility features are provided by Drupal 8 and contributed Drupal 8 modules. These pages within the Accessibility section of the Drupal documentation can provide guidance:
|
Very good catch. We should follow our own recommendations. I will update.
… On Dec 8, 2019, at 12:28 PM, Rosemary Le Faive ***@***.***> wrote:
@rosiel commented on this pull request.
In docs/user-documentation/accessibility.md:
> @@ -0,0 +1,3 @@
+Islandora 8 leans heavily on Drupal for accessibility. Drupal 8 core comes with a number of features to support greater accessibility for developers, site builders, and end users, as outlined [here](https://www.drupal.org/docs/8/accessibility/drupal-8-accessibility-features). This can be extended further with contributed modules, as outlined [here](https://www.drupal.org/docs/8/accessibility/contributed-modules-for-extending-accessibility-in-drupal-8)
I like that we are putting this in here and don't want to block it. However, I think rephrasing to avoid using the word "here" as link text may be advisable by said accessibility guidelines. For example:
Islandora 8's accessibility features are provided by Drupal 8 and contributed Drupal 8 modules. These pages within the Accessibility section of the Drupal documentation can provide guidance:
Drupal 8 Accessibility Features
Contributed Modules for Extending Accessibility in Drupal 8
Hide Content Properly (for all users including users with screen readers)
How to do an accessibility review?
List of External Accessibility Resources
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #1040
What does this Pull Request do?
Adds a brief page addressing accessibility. Mostly just pointing to Drupal 8 resources, but even if we don't have our own Islandora-specific accessibility tools at this point, I think it's useful to have guidance in our docs about what's out there.
What's new?
New page and new entry in the mkdoc file.
How should this be tested?
Preview the page, test the links.
Interested parties
@Islandora/8-x-committers