Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Bad link to documentation on https://www.islandora.ca/docs #2232

Closed
kayakr opened this issue May 23, 2023 · 3 comments
Closed

[DOCS] Bad link to documentation on https://www.islandora.ca/docs #2232

kayakr opened this issue May 23, 2023 · 3 comments
Assignees

Comments

@kayakr
Copy link
Contributor

kayakr commented May 23, 2023

On https://www.islandora.ca/docs, the Documentation link to "Learn More" circles back to /docs, rather than (I assume) https://islandora.github.io/documentation/ per the footer link to Documentation.

Also the link uses target="_blank" that should also have rel="noreferrer noopener" as only more recent browsers have default protection against window.opener API exploitation attacks https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#security_and_privacy

@kstapelfeldt kstapelfeldt self-assigned this May 24, 2023
@kstapelfeldt
Copy link
Member

Hello! Thank you so much for reporting. I just tried to fix it. Did it work?

@kayakr
Copy link
Contributor Author

kayakr commented May 24, 2023

Hello! Thank you so much for reporting. I just tried to fix it. Did it work?

Yep, link works now, thanks. Where is the codebase for the site? Next time I can contribute a PR.

@kstapelfeldt
Copy link
Member

That's a kind thought and I wish it worked that way - we are using this hosted online product called WebFlow. On the plus side, it's pretty easy for people to go in and make changes, so feel free to report anything additional and @ me.

@ysuarez ysuarez closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants