Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to use "Media Tab" without having field_member_of #1893

Open
rosiel opened this issue Sep 3, 2021 · 0 comments
Open

Should be able to use "Media Tab" without having field_member_of #1893

rosiel opened this issue Sep 3, 2021 · 0 comments
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)

Comments

@rosiel
Copy link
Member

rosiel commented Sep 3, 2021

Title (Goal) Have the option an Islandora content type that doesn't have field_member_of
Primary Actor Repository admin
Scope Architecture
Level High
Story As a repository admin, I want to make new content types that work with Islandora. I want to make the decision about whether a content can "have media" separately from whether that same content type can "be a member of" another node. For example, I might use taxonomy terms for organization. I want the option to not add field_member_of to my Islandora content.

Relevant architecture and proposals for how logic could work:

  • in the access() function that determines whether the "Members" tab appears, ManageMembersController currently requires both field_model and field_member_of be on the node.
    • Instead, this should check whether any nodes have 'field_member_of' which can be pointed to this content type.
  • In the access() function that determines whether the "Media" tab appears, ManageMediaController currently requires both field_model and field_member_of to be on the node.
    • I propose we rename the configuration option in the Core Islandora Settings, currently displaying Fedora URLs for selected bundles, to be a more generic "which content types are Islandora" setting, and use that to determine whether the Media tab should display on nodes.

Making these changes, Islandora Defaults would still work the same.

@kstapelfeldt kstapelfeldt added Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’) bug and removed architecture labels Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)
Projects
Development

No branches or pull requests

2 participants