islandora_base_theme image field template preprocess drops image URL

[alxp]

Investigating why Media pages of images seem to all have broken images in islandora_base_theme.

I found this template preprocess function that adds an IIIF viewer to the image field.

In the preprocess function we find:

    $file_url = file_create_url($variables['uri']);
    if (strpos($file_url, '/system/temporary') === false) {
      $file_url = strstr($file_url, '?', TRUE);
    }

My file URL does not contain a ? so the part inside the if statement is always replacing the URL with FALSE.

[dannylamb]

Those changes are straightforward. I wouldn't be surprised to bump into other issues with this along the way. Which makes me not too receptive to this feature. Feels like we're doing it just to say we use IIIF, and it's not neccessary considering we already generate image styles 🤷