Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

islandora_fits not D9 ready #1742

Closed
seth-shaw-unlv opened this issue Jan 13, 2021 · 2 comments
Closed

islandora_fits not D9 ready #1742

seth-shaw-unlv opened this issue Jan 13, 2021 · 2 comments
Assignees
@ajstanley

Comments

@seth-shaw-unlv
Copy link
Contributor

While testing the new D9 islandora parts I stumbled across this error when attempting to view a FITS record: Error: Call to undefined method Drupal\file\Entity\File::url() in Drupal\islandora_fits\Plugin\Field\FieldFormatter\FitsFormatter->viewValue() (line 79 of /var/www/html/drupal/web/modules/contrib/islandora_fits/src/Plugin/Field/FieldFormatter/FitsFormatter.php). The url function was deprecated in D8 and was removed in D9.

We should update the offending line and check for any other deprecated code.

Tagging #1680 and @ajstanley.
@ajstanley ajstanley self-assigned this Jan 14, 2021
@ajstanley
Copy link
Contributor

An easy one-liner. Change has been pushed and tested in 8 & 9

@seth-shaw-unlv
Copy link
Contributor Author

Rebuilt the D9 site and all is well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajstanley ajstanley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajstanley @seth-shaw-unlv