Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumbs don't apply for top-level items #1590

Closed
seth-shaw-unlv opened this issue Aug 26, 2020 · 1 comment
Closed

Breadcrumbs don't apply for top-level items #1590

seth-shaw-unlv opened this issue Aug 26, 2020 · 1 comment

Comments

@seth-shaw-unlv
Copy link
Contributor

The breadcrumbs applies function doesn't apply if the configured 'member_of' field is empty. However, this means collections without parents don't apply and the system breadcrumbs will take over adding 'Node' to the beginning. 🤦‍♂️

We should simply check if the configured field exists on the object.
@seth-shaw-unlv
Copy link
Contributor Author

Huh, I should have read #1367 because @qadan already pointed out that items with empty member_of fields don't get picked up. I'm closing this as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seth-shaw-unlv