Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: LinkHeaderSubscriber throws exceptions when attempting to generate links for entities without canonical URLs #1551

Closed
adam-vessey opened this issue Jun 24, 2020 · 1 comment
Closed

Bug: LinkHeaderSubscriber throws exceptions when attempting to generate links for entities without canonical URLs #1551

adam-vessey opened this issue Jun 24, 2020 · 1 comment

Comments

@adam-vessey
Copy link
Contributor

In LinkHeaderSubscriber::generateEntityReferenceLinks(), we attempt to generate canonical URLs for all referenced entities, expecting that all referenced entities have canonical URLs; however, this is not the case. Some entities (such as block entities) do not specify a canonical URL template by default.

... This leads to errors and whitescreens when attempting to deal with this content.
@adam-vessey adam-vessey mentioned this issue Jun 24, 2020
Merged
@dannylamb
Copy link
Contributor

resolved via Islandora/islandora@bfa2c39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adam-vessey @dannylamb