Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding with fedora #1532

Open
adam-vessey opened this issue Jun 2, 2020 · 2 comments
Open

Binding with fedora #1532

adam-vessey opened this issue Jun 2, 2020 · 2 comments
Labels
Type: bug identifies a problem in the software with clear steps to reproduce

Comments

@adam-vessey
Copy link
Contributor

In Islandora/islandora#742, explicit references to configuration of Fedora in were made in code, causing warnings should a system be setup and configured without it.

@adam-vessey
Copy link
Contributor Author

Discussed during the 2020-09-02 I8 tech call. @elizoller pointed out the use of the set property in https://github.com/Islandora/Alpaca/blob/f4af9b97475cf2b64822836be6f65a7453b537c1/islandora-indexing-fcrepo/src/main/java/ca/islandora/alpaca/indexing/fcrepo/FcrepoIndexer.java#L152

Discussion seemed to indicate that an isset() check around the access should be sufficient, with anything downstream which expects the value to be there should be made to deal with its existence.

@jordandukart
Copy link
Member

This has popped in the D9 sprint as PHP 7.4 now throws warnings when encountering this: https://www.php.net/manual/en/migration74.incompatible.php#migration74.incompatible.core.non-array-access.

@kstapelfeldt kstapelfeldt added Type: bug identifies a problem in the software with clear steps to reproduce and removed bug labels Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug identifies a problem in the software with clear steps to reproduce
Projects
Development

No branches or pull requests

3 participants