Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the islandora_version_count table used for? #1528

Closed
mjordan opened this issue May 31, 2020 · 6 comments
Closed

What is the islandora_version_count table used for? #1528

mjordan opened this issue May 31, 2020 · 6 comments

Comments

@mjordan
Copy link
Contributor

mjordan commented May 31, 2020

islandora.install creates the db table islandora_version_count, which is annotated as 'Keeps track of the number of changes to an entity'. However, grepping through the contrib modules directory only reveals a single use of 'islandora_version_count', in the .install file, and creating a new revision of a node doesn't add anything to the table. Is this still in use, and if so, what populates it?

@whikloj
Copy link
Member

whikloj commented Jun 1, 2020

Ohhhhh waaaaay back (yes kids, there was a time before COVID-19) that was going to be how we enforced write order to Fedora. To ensure that in the case of two instantaneous edits we didn't end up with the wrong state in Fedora compared to Drupal we would check that the counter of the new write was one more than the counter of the current document. It may not be needed anymore but we haven't done a lot of multi-edit testing and depending on how asynchronous your Fedora is this could still be an issue.

@mjordan
Copy link
Contributor Author

mjordan commented Jun 1, 2020

Ah. Thanks for the background.

@mjordan
Copy link
Contributor Author

mjordan commented Jun 3, 2020

Should I just close this?

@whikloj
Copy link
Member

whikloj commented Jun 3, 2020

🤷

@dannylamb
Copy link
Contributor

dannylamb commented Jun 3, 2020

Burn it with 🔥?

We didn't implement it... and may very well never...

@seth-shaw-unlv
Copy link
Contributor

Resolved with Islandora/islandora@0097808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants