Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy openseadragon js with composer #1518

Closed
dannylamb opened this issue May 21, 2020 · 5 comments · Fixed by Islandora/openseadragon#26
Closed

Deploy openseadragon js with composer #1518

dannylamb opened this issue May 21, 2020 · 5 comments · Fixed by Islandora/openseadragon#26

Comments

@dannylamb
Copy link
Contributor

Openseadragon can be installed with npm, so it should be available to composer. We can use this to keep the version of openseadragon consistent and also streamline installation. One less thing...

@dannylamb
Copy link
Contributor Author

Looks like there's no real consensus on how to do this within the Drupal community, with the leading technique involving modifying your site's root composer file. It may be best to hold off for a while until this sorts itself out.

I am looking to update the install location to the standard web/libraries folder, though, just so we don't have to stick things in web/sites/all/vendor/assets, which is causing some minor problems in ISLE.

@dannylamb
Copy link
Contributor Author

Wound up pulling it from a CDN. Way simpler and still lets us manage the version of the library within the module.

@DiegoPino
Copy link
Contributor

DiegoPino commented Jul 15, 2020

We have been doing this for every JS for more 2 years already and no larger issue on production.

See https://github.com/esmero/format_strawberryfield/blob/8.x-1.0-beta3/format_strawberryfield.libraries.yml

A few notes:

  • Sometimes CDN goes down. Subscribed to notifications and Twitter (helps)
  • Openseadragon license IS NOT GPL compatible.

@dannylamb
Copy link
Contributor Author

Good to hear you haven't had many problems with it (other than of course if the CDN goes down).

I did a quick googling and found the license to be gpl compatible, but it was hasty. I'll double check that. Thanks for the heads up.

@mjordan
Copy link
Contributor

mjordan commented Jul 15, 2020

I was involved recently in troubleshooting Islandora-Labs/islandora_usage_stats_charts#28, and the solution was to move the Chart.js Javascript library from a CDN (cloudflare) to a local copy. I never figured out why the CDN version stopped working, but perhaps @bondjimbond can offer some info if he has any. Best guess is that some caching he or his support vendor had implemented interfered, but that's just a guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants