Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Drupal's file upload capabilities #1517

Open
dannylamb opened this issue May 21, 2020 · 3 comments
Open

Use Drupal's file upload capabilities #1517

dannylamb opened this issue May 21, 2020 · 3 comments
Labels
Type: enhancement Identifies work on an enhancement to the Islandora codebase

Comments

@dannylamb
Copy link
Contributor

Between core REST file uploads, JSON:API file uploads, and modules such as file_upload_options, we can completely drop our custom REST endpoints. This functionality didn't exist when the project started, but it does now and we should take advantage of it.

We would be able to eliminate the MediaSourceController and most of the MediaSourceService, and whatever's remaining could probably just get rolled into IslandoraUtils.

We would have to rework what gets pumped onto the queues and islandora-connector-derivative to utilize the new methods of uploading files.

@dannylamb
Copy link
Contributor Author

@mjordan @seth-shaw-unlv Workbench would also be affected

@mjordan
Copy link
Contributor

mjordan commented May 21, 2020

Shouldn't be too bad, other than changing the endpoint URLs, I would imagine. I agree that getting rid of our custom enpoints is a good idea.

@ajstanley
Copy link
Contributor

That is going to affect the multifile module as well - I've got a custom endpoint to attach files to existing media, and another endpoint for extracted text to both attach the file and stick the contents in an editable field.

@kstapelfeldt kstapelfeldt added Type: enhancement Identifies work on an enhancement to the Islandora codebase and removed enhancement labels Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement Identifies work on an enhancement to the Islandora codebase
Projects
Development

No branches or pull requests

4 participants