Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicating 7.x's collapsable "Details" display #1359

Open
mjordan opened this issue Nov 21, 2019 · 9 comments
Open

Replicating 7.x's collapsable "Details" display #1359

mjordan opened this issue Nov 21, 2019 · 9 comments
Labels
Subject: Metadata related to metadata issues. Consider also using the search tag.

Comments

@mjordan
Copy link
Contributor

mjordan commented Nov 21, 2019

Islandora 7.x's metadata display was wrapped in a collapsable div that allowed the user to expand/collapse:

Collapsed:

lasers1

Expanded:

lasers2

In Islandora 8, the metadata fields are always exposed (similar to the expanded option above). Do we want to emulate 7.x's behavior in 8, or at least provide a built-in option to do so?

@mjordan
Copy link
Contributor Author

mjordan commented Nov 21, 2019

I'll check out https://www.drupal.org/project/field_group to see if this does the trick.

@seth-shaw-unlv
Copy link
Contributor

seth-shaw-unlv commented Nov 21, 2019

I was just about to recommend field_group for doing this. However, perhaps this should be a recipe instead of a default (to limit the default install weight)?

@mjordan
Copy link
Contributor Author

mjordan commented Nov 21, 2019

Agreed. I'm trying to test it now but the composer install failed. Will resume testing/troubleshooting later.

@mjordan
Copy link
Contributor Author

mjordan commented Nov 23, 2019

Field Group works well. Here is my field group (lower left, it's circled in red to make it more visible) closed by default:

closed

Clicking on the "Metadata" label opens it:

open

It a bit clunky to set up. One thing is that it looks like admins will need to configure this separately for every display/view mode (default, PDFjs, OpenSeadragon, etc.):

fieldgroupconfig

But once it's done, it's set and forget. It looks like the field group config is portable:

fieldgroupyaml

So maybe it could become part o the standard setup?

@mjordan
Copy link
Contributor Author

mjordan commented Nov 23, 2019

Tagging @manez as this would be good candidate for a recipe.

@mjordan mjordan changed the title Do we want to keep the collapsable "Details" display from Islandora 7? Replicating 7.x's collapsable "Details" display Nov 23, 2019
@manez
Copy link
Member

manez commented Dec 11, 2019

Finally got to this one on the tech call today, with a resounding "yes" for doing it as a recipe and not as a default.

@mjordan
Copy link
Contributor Author

mjordan commented Apr 29, 2021

@manez, where do recipes fit into the DIG's current workplan?

@manez
Copy link
Member

manez commented Apr 29, 2021

@mjordan https://github.com/Islandora-Labs/Islandora-Cookbook is still the home base for recipes. We've talked about evaluating whether those should get rolled into the main docs at some point, but that's pretty far ahead, and would build from what's in the github repo anyway.

@mjordan
Copy link
Contributor Author

mjordan commented Apr 29, 2021

OK, thanks. I'll write up a recipe and open a PR on that repo.

@kstapelfeldt kstapelfeldt added Subject: Metadata related to metadata issues. Consider also using the search tag. and removed Metadata labels Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subject: Metadata related to metadata issues. Consider also using the search tag.
Projects
Development

No branches or pull requests

4 participants