Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test OpenSeadragon and Mirador to make sure CORS configuration is not necessary #1358

Closed
mjordan opened this issue Nov 21, 2019 · 5 comments
Closed

Comments

@mjordan
Copy link
Contributor

mjordan commented Nov 21, 2019

Coming out of a discussion over at #1294 between me and @seth-shaw-unlv, we should test OpenSeadragon in a variety of client/server IP address combinations to make sure that we don't need to configure Drupal's CORS settings. I have been seeing some inconsistent behaviors testing Islandora on my home network using 192.168. addresses and public IP addresses. The OpenSeadragon github issue queue has lots of references to CORS so I suspect that we'll need to document something around this.

CORS is, apparently, not documented anywhere on the d.o. website yet the options exist in sites/default/default.services.yml, which must be adjusted and then copied to sites/default/services.yml, and then cache cleared.

@mjordan mjordan changed the title Test OpenSeadragon to make sure CORS configuration is not necessary Test OpenSeadragon and Mirador to make sure CORS configuration is not necessary Nov 21, 2019
@mjordan
Copy link
Contributor Author

mjordan commented Nov 21, 2019

We should test Mirador too when Islandora/islandora_defaults#10 gets merged (or even prior to that).

@mjordan
Copy link
Contributor Author

mjordan commented Nov 26, 2019

Some useful examples at https://www.drupal.org/node/2715637.

@dannylamb
Copy link
Contributor

Bumping into this now with ISLE and openseadragon. It's totally a thing.

@dannylamb
Copy link
Contributor

Just to circle back to this one. We solved this in ISLE with Traefik (the front end proxy to the whole stack). TL;DR even though they're separate containers/servers, if you expose cantaloupe and matomo as sub-paths off the main site, there's no CORS. E.g. if your Drupal is at http://example.org, cantaloupe is at http://example.org/cantaloupe and matomo is at http://example.org/matomo. Otherwise, yes, you gotta set up CORS and it's a PITA.

@dannylamb
Copy link
Contributor

I think we can close this one. Feel free to re-open if neccessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants