Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RECAST_DRUPAL_URL and RECAST_FCREPO_URL values #220

Closed
misilot opened this issue May 17, 2022 · 14 comments
Closed

RECAST_DRUPAL_URL and RECAST_FCREPO_URL values #220

misilot opened this issue May 17, 2022 · 14 comments
Assignees
Labels

Comments

@misilot
Copy link
Contributor

misilot commented May 17, 2022

https://github.com/Islandora-Devops/isle-buildkit/blob/main/recast/Dockerfile#L15-L16

Should these values be?

RECAST_DRUPAL_URL=http://drupal:80
RECAST_FCREPO_URL=http://fcrepo:8080/fcrepo/rest

@nigelgbanks
Copy link
Contributor

Not 100% sure things that communicate back with islandora are a bit weird in that they require the external url, for some aspects to work. I've not been using fedora in most of the setups I have. @dannylamb do you want to weight in?

@dannylamb
Copy link
Member

I think you want those to be the real domain of the site, since that'll be what gets slapped into the fedora document when you view it through the recast service.

It's been a hot minute since I last used that service though. I pulled it out of deployments for BD just to keep things leaner.
@misilot are you trying to use recast and running into problems?

@misilot
Copy link
Contributor Author

misilot commented May 19, 2022

@dannylamb no, and I'll be honest I have no clue what recast is ...

I am seeing errors in alpaca and milliner in the logs, so it had me start going through things, and looking at the different environments trying to figure out what might be wrong and saw that set as islandora.traefik.me ...., and with the change of the fedora port from 80 to 8080 made me start digging more in case it was that ...

@g7morris
Copy link
Contributor

g7morris commented Sep 6, 2022

@dannylamb & @nigelgbanks Is this still an issue to pursue?

@g7morris
Copy link
Contributor

g7morris commented Sep 6, 2022

I would argue we don't want to be hardcoding ANY domain at all here but rather use a variable from the .env file e.g. DOMAIN=

or we should copy what other services do here e.g. milliner https://github.com/Islandora-Devops/isle-buildkit/blob/main/milliner/Dockerfile#L16 seems to use the fcrepo service MILLINER_FCREPO_URL=http://fcrepo:8080/fcrepo/rest \

@g7morris
Copy link
Contributor

g7morris commented Sep 6, 2022

@nigelgbanks Do you want to schedule a Zoom call re this task or talk in Slack sometime this week to divvy up next steps between the two of us?

@g7morris g7morris added the fcrepo label Sep 7, 2022
@nigelgbanks
Copy link
Contributor

nigelgbanks commented Sep 7, 2022

Recast doesn't appear to be working, I'm currently investigating...

Well, it wasn't deployed to sandbox, so that's not a surprise. I'm testing isle-dc now...

@whikloj
Copy link
Member

whikloj commented Sep 7, 2022

Popping in to say that Recast is (to my knowledge) not being used anywhere. It was developed to provide a way generate Fedora URIs for things that are Drupal links. It used to look them up in Gemini and now just uses the internal UUID generator that @dannylamb made.

We never figured out a good way to cause the RDF in Fedora to get run through this tool and updated to include these new triples.

All that is to say, this does not need to be a high priority.

@nigelgbanks
Copy link
Contributor

@dannylamb should I remove the recast image then? No point in building it if we aint gonna use it.

@dannylamb
Copy link
Member

Go right ahead. If we have @whikloj 's blessing then burn it. 🔥 🔥 🔥

@g7morris
Copy link
Contributor

@nigelgbanks Are you going to remove the recast image or does @whikloj need to say a few nice words before we set recast's funeral pyre off?

@nigelgbanks
Copy link
Contributor

If @dannylamb is fine with axing it I'll just remove it seeing as we've not actually used it for well years... 😄

@nigelgbanks
Copy link
Contributor

Since this is removing an image though, we'll push it off to the 2.0 release

@nigelgbanks
Copy link
Contributor

Done under #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants