Feat: random bundles test #23
Conversation
ghost
changed the title
ghost
force-pushed
the
feat/random-bundles-test
branch
from
3ea4ebb to
b1007df
Compare
ghost
force-pushed
the
feat/random-bundles-test
branch
from
b1007df to
f0bf695
Compare
examples/fund.rs
Outdated
| @@ -7,8 +7,10 @@ use reqwest::Url; | |||
| async fn main() { | |||
| let url = Url::parse("https://node1.bundlr.network").unwrap(); | |||
| let wallet = PathBuf::from_str("res/test_wallet.json").unwrap(); | |||
| let currency = Arweave::new(wallet, None); | |||
| let bundlr = Bundlr::new(url, ¤cy).await; | |||
| let currency = Arweave::new(wallet, None).expect("Could not create currency"); | |||
There was a problem hiding this comment.
Also, this design is really weird. Why would you pass wallet or any other arguments to the currency instance? There's something missing with this abstraction.
There was a problem hiding this comment.
Some functionalities from Currency needs private key. The main idea was to have this as an option
There was a problem hiding this comment.
When looking at the Currency trait, I can see there are some mistakes in the design (which require you to pass wallet/signer to the Currency instance):
get_txandget_tx_statusare really weird ones there, why would you ask information about transactions from a currency?get_current_height, what does this to do with a currency?- all signing and verifying of transactions, these are signer's (or wallet's) functionalities, not currency's
price, this is either not something a currency should provide, this is something exchange tells you
Looking at the trait, about 90% of it is in a wrong place.
|
|
||
| #[cfg(feature = "aptos")] | ||
| use crate::MultiAptosSigner; | ||
|
|
||
| use crate::error::BundlrError; | ||
|
|
||
| #[derive(FromPrimitive, Display, PartialEq, Eq, Debug, Clone)] | ||
| pub enum SignerMap { |
There was a problem hiding this comment.
I wanted to bring this up quite some time so doing it now: this type name is quite bad, it always makes me wonder what is this about until I look at the definition. Maybe this should be renamed to SignerType or something else. In the end, it's not a Map type, it's an enumeration.
| <[u8; 2]>::try_from(sig_type_b) | ||
| .map_err(|err| BundlrError::BytesError(err.to_string()))?, |
There was a problem hiding this comment.
I would move this to a separate variable and pass it here. Would make the code a bit cleaner.
tsconfig.json
Outdated
| "strict": true, | ||
| "resolveJsonModule": true | ||
| }, | ||
| } |
There was a problem hiding this comment.
Missing new line at the end of the file. Please, fix your editor.
There was a problem hiding this comment.
Please move all of this nodejs specific code into a separate subdir.
Signed-off-by: Blue Kirby <blue.kirby@tutanota.com>
| node_modules | ||
| dist | ||
| /res/gen_bundles/bundle* | ||
| bundles.js |
There was a problem hiding this comment.
Missing newline. Fix your editor.
|
Smaller issues noted, I'll address them soon |
Adds random bundles generation and tests within rust-sdk