Reduce scope of pulling OpenSSL as a dependency #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dropping `ethereum` and `erc20` features, we can drop also OpenSSL as a dependency. Currently `web3` crate cause `openssl` to be pulled as a dependency no matter which features are enabled or disabled. But at least if these features are not needed, we can now drop OpenSSL when configuring `reqwest` dependency correctly.
|
For now, web3 can't be removed. Needs further implementation of ERC20 and Ethereum signing/verification without it. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dropping
ethereumanderc20features, we can drop also OpenSSL as a dependency. Currentlyweb3crate causeopensslto be pulled as a dependency no matter which features are enabled or disabled.But at least if these features are not needed, we can now drop OpenSSL when configuring
reqwestdependency correctly.