fix #310, onFinish outside the slider #312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #310
In the pointerUp function, the callOnFinish() callback is call if we release the click inside the slider or if we are in dragging mode, line 736.
Unfortunately, the dragging mode is set to false just before ! line 727.
And the onFinish is never call
http://jsfiddle.net/sbx6zcnm/3/
I have move the this.dragging = false at the end of the function and it works fine, but I don't know all the consequences !
http://jsfiddle.net/sbx6zcnm/4/