Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid_snap crashes Chrome and Edge #438

Closed
MSCAU opened this issue Jan 8, 2017 · 3 comments
Closed

grid_snap crashes Chrome and Edge #438

MSCAU opened this issue Jan 8, 2017 · 3 comments
Assignees
Labels
[bug] low priority Bug or not a bug?

Comments

@MSCAU
Copy link

MSCAU commented Jan 8, 2017

Hi Den,

It looks as though grid_snap: true crashes the browser with 2.1.6. Seems to get caught in a loop. I have tested this with latest Chrome and Edge:

<script src="https://code.jquery.com/jquery-1.11.3.min.js"></script>
<script>
  $(function() {
  	$("#slider_budget").ionRangeSlider({
	    type: "double",
	    // grid_snap: true,  // This line crashes the browser
	    grid: true,
	    min: 0,
	    max: 80000,
	    from: 2000,
	    to: 30000,
	    prefix: "$ ",
	    hide_min_max: true,
            prettify_enabled: true,
    	    prettify_separator: ","
   	});
  });
</script>

I don't know why it works on your demo page...

@IonDen
Copy link
Owner

IonDen commented Jan 13, 2017

Hi, thanks for finding this. This is happens because of too much calculations. Check this demo:
http://jsfiddle.net/IonDen/7hhasqyo/ if will see that it is looking ugly already.

So, the best way to handle the problem is to add STEP to config, like this:
http://jsfiddle.net/IonDen/g73upq85/

To avoid this problem in the future i will add some check to the code.

@IonDen IonDen self-assigned this Jan 13, 2017
@IonDen IonDen added the [bug] low priority Bug or not a bug? label Jan 13, 2017
@MSCAU
Copy link
Author

MSCAU commented Jan 13, 2017

OK thanks. That will do for now.

@IonDen
Copy link
Owner

IonDen commented Mar 26, 2017

Fixed in 2.1.7

@IonDen IonDen closed this as completed Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[bug] low priority Bug or not a bug?
Projects
None yet
Development

No branches or pull requests

2 participants